-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dbus-cpp: init at 5.0.3 #260941
Merged
Merged
dbus-cpp: init at 5.0.3 #260941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OPNA2608
force-pushed
the
init/lomiri/dbus-cpp
branch
from
October 13, 2023 20:52
3f54a7c
to
27e5394
Compare
ofborg
bot
added
8.has: package (new)
This PR adds a new package
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
Oct 13, 2023
OPNA2608
force-pushed
the
init/lomiri/dbus-cpp
branch
from
October 14, 2023 00:33
27e5394
to
2cad530
Compare
OPNA2608
force-pushed
the
init/lomiri/dbus-cpp
branch
from
October 14, 2023 08:03
2cad530
to
fd04990
Compare
12 tasks
Tests seem very flaky on some systems / for some ppl. Consistently fail on OfBorg ARM CI, past reports of sporadic test failures on amd64. Not sure if due to weak systems or DBus weirdness. Disabling for now.
Result of 4 packages built:
|
mrcjkb
approved these changes
Oct 14, 2023
OPNA2608
added
the
12.approvals: 1
This PR was reviewed and approved by one reputable person
label
Oct 14, 2023
12 tasks
lomiri.mediascanner2 errored due to includedir being a non-existent path. TIL our pkg-config patcher requires ${prefix} to work.
Re-tested by packaging more packages that depend on this, and eventually noticed that it was missing a fix:
Should be good-er now. |
OPNA2608
removed
the
12.approvals: 1
This PR was reviewed and approved by one reputable person
label
Oct 18, 2023
12 tasks
Result of 4 packages built:
|
mrcjkb
approved these changes
Oct 19, 2023
delroth
added
the
12.approvals: 1
This PR was reviewed and approved by one reputable person
label
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
10.rebuild-linux: 1
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
12.approvals: 1
This PR was reviewed and approved by one reputable person
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Working towards #99090.
dbus-cpp, a C++11 dbus-binding. Repo says it's header only, squints at monitor but it builds a library to link against. Oh well. Needed by Lomiri's location service, biometry daemon, mediascanner2 service & trust store.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)