Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbus-cpp: init at 5.0.3 #260941

Merged
merged 3 commits into from
Oct 21, 2023
Merged

dbus-cpp: init at 5.0.3 #260941

merged 3 commits into from
Oct 21, 2023

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Oct 13, 2023

Description of changes

Working towards #99090.

dbus-cpp, a C++11 dbus-binding. Repo says it's header only, squints at monitor but it builds a library to link against. Oh well. Needed by Lomiri's location service, biometry daemon, mediascanner2 service & trust store.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@OPNA2608 OPNA2608 force-pushed the init/lomiri/dbus-cpp branch from 3f54a7c to 27e5394 Compare October 13, 2023 20:52
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 13, 2023
@OPNA2608 OPNA2608 force-pushed the init/lomiri/dbus-cpp branch from 27e5394 to 2cad530 Compare October 14, 2023 00:33
@OPNA2608 OPNA2608 force-pushed the init/lomiri/dbus-cpp branch from 2cad530 to fd04990 Compare October 14, 2023 08:03
@OPNA2608 OPNA2608 mentioned this pull request Oct 14, 2023
12 tasks
Tests seem very flaky on some systems / for some ppl. Consistently fail on OfBorg ARM CI, past reports of
sporadic test failures on amd64. Not sure if due to weak systems or DBus weirdness. Disabling for now.
@mrcjkb
Copy link
Member

mrcjkb commented Oct 14, 2023

Result of nixpkgs-review pr 260941 run on x86_64-linux 1

4 packages built:
  • dbus-cpp
  • dbus-cpp.dev
  • dbus-cpp.doc
  • dbus-cpp.examples

@OPNA2608 OPNA2608 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 14, 2023
lomiri.mediascanner2 errored due to includedir being a non-existent path.
TIL our pkg-config patcher requires ${prefix} to work.
@OPNA2608
Copy link
Contributor Author

Re-tested by packaging more packages that depend on this, and eventually noticed that it was missing a fix:

CMake Error in src/qml/MediaScanner.0.1/CMakeLists.txt:
  Imported target "PkgConfig::DBUSCPP" includes non-existent path

    "/nix/store/jz9cc5mrw7vw9mrqmyp4xs1rhn0q4p4v-dbus-cpp-5.0.3/include"

Should be good-er now.

@OPNA2608 OPNA2608 removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 18, 2023
@OPNA2608 OPNA2608 requested a review from mrcjkb October 18, 2023 22:10
@mrcjkb
Copy link
Member

mrcjkb commented Oct 19, 2023

Result of nixpkgs-review pr 260941 run on x86_64-linux 1

4 packages built:
  • dbus-cpp
  • dbus-cpp.dev
  • dbus-cpp.doc
  • dbus-cpp.examples

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 19, 2023
@wegank wegank merged commit b091a2a into NixOS:master Oct 21, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants