Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lomiri.lomiri-thumbnailer: init at 3.0.2 #259740

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Oct 8, 2023

Description of changes

Working towards #99090.

Lomiri Thumbnailer is a background service for generating thumbnails to media. Used by Lomiri itself, and most of its media-related apps (music app, gallery app, file manager, messaging app...?).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-thumbnailer branch from 29293bb to 8b28d09 Compare October 8, 2023 10:03
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels Oct 8, 2023
@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-thumbnailer branch from 8b28d09 to e7b67dd Compare December 18, 2023 15:30
@OPNA2608

This comment was marked as resolved.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 2.status: merge conflict This PR has merge conflicts with the target branch and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 labels Dec 18, 2023
@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-thumbnailer branch from 14e45bf to 943a515 Compare December 23, 2023 21:38
@OPNA2608 OPNA2608 marked this pull request as ready for review December 23, 2023 21:39
@OPNA2608 OPNA2608 removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 23, 2023
@OPNA2608 OPNA2608 changed the title lomiri.lomiri-thumbnailer: init at 3.0.1 lomiri.lomiri-thumbnailer: init at 3.0.2 Dec 30, 2023
@OPNA2608 OPNA2608 marked this pull request as draft December 30, 2023 02:03
@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-thumbnailer branch from 943a515 to 6b4adf3 Compare December 30, 2023 23:14
@OPNA2608 OPNA2608 marked this pull request as ready for review December 30, 2023 23:35
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3246

@OPNA2608

This comment was marked as resolved.

@OPNA2608 OPNA2608 marked this pull request as draft January 12, 2024 22:07
@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-thumbnailer branch from 6b4adf3 to 8c56531 Compare January 14, 2024 17:27
@OPNA2608 OPNA2608 marked this pull request as ready for review January 14, 2024 17:28
@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-thumbnailer branch 2 times, most recently from 6f8b28d to 2e20672 Compare January 20, 2024 00:08
@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-thumbnailer branch from 2e20672 to faeaadb Compare January 20, 2024 16:20
@pbsds
Copy link
Member

pbsds commented Jan 22, 2024

Result of nixpkgs-review pr 259740 run on x86_64-linux 1

3 packages built:
  • lomiri.lomiri-thumbnailer
  • lomiri.lomiri-thumbnailer.dev
  • lomiri.lomiri-thumbnailer.doc

Runs fine and LGTM

@pbsds pbsds merged commit 98b7ab9 into NixOS:master Jan 22, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants