Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.libnacl: 1.7.2 -> 2.1.0 #257866

Merged
merged 1 commit into from
Oct 13, 2023
Merged

python3Packages.libnacl: 1.7.2 -> 2.1.0 #257866

merged 1 commit into from
Oct 13, 2023

Conversation

pbsds
Copy link
Member

@pbsds pbsds commented Sep 28, 2023 •
edited
Loading

Description of changes

I'm on a mission to get rid of patches tagged in releases upstream

Diff: saltstack/libnacl@v1.7.2...v2.1.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@pbsds
Copy link
Member Author

pbsds commented Sep 28, 2023

Result of nixpkgs-review pr 257866 run on x86_64-linux 1

37 packages built:
  • dvc (python310Packages.dvc)
  • dvc-with-remotes
  • dvc-with-remotes.dist
  • dvc.dist (python310Packages.dvc.dist)
  • home-assistant-component-tests.asuswrt
  • moonraker
  • python310Packages.aioasuswrt
  • python310Packages.aioasuswrt.dist
  • python310Packages.asyncssh
  • python310Packages.asyncssh.dist
  • python310Packages.dvc-ssh
  • python310Packages.dvc-ssh.dist
  • python310Packages.dvclive
  • python310Packages.dvclive.dist
  • python310Packages.libnacl
  • python310Packages.libnacl.dist
  • python310Packages.scmrepo
  • python310Packages.scmrepo.dist
  • python310Packages.sshfs
  • python310Packages.sshfs.dist
  • python311Packages.aioasuswrt
  • python311Packages.aioasuswrt.dist
  • python311Packages.asyncssh
  • python311Packages.asyncssh.dist
  • python311Packages.dvc
  • python311Packages.dvc-ssh
  • python311Packages.dvc-ssh.dist
  • python311Packages.dvc.dist
  • python311Packages.dvclive
  • python311Packages.dvclive.dist
  • python311Packages.libnacl
  • python311Packages.libnacl.dist
  • python311Packages.scmrepo
  • python311Packages.scmrepo.dist
  • python311Packages.sshfs
  • python311Packages.sshfs.dist
  • tribler

@pbsds pbsds marked this pull request as ready for review September 28, 2023 17:48
@ofborg ofborg bot requested a review from xvapx September 28, 2023 17:56
@fabaff
Copy link
Member

fabaff commented Sep 28, 2023

Result of nixpkgs-review pr 257866 run on x86_64-linux 1

37 packages built:
  • dvc (python310Packages.dvc)
  • dvc-with-remotes
  • dvc-with-remotes.dist
  • dvc.dist (python310Packages.dvc.dist)
  • home-assistant-component-tests.asuswrt
  • moonraker
  • python310Packages.aioasuswrt
  • python310Packages.aioasuswrt.dist
  • python310Packages.asyncssh
  • python310Packages.asyncssh.dist
  • python310Packages.dvc-ssh
  • python310Packages.dvc-ssh.dist
  • python310Packages.dvclive
  • python310Packages.dvclive.dist
  • python310Packages.libnacl
  • python310Packages.libnacl.dist
  • python310Packages.scmrepo
  • python310Packages.scmrepo.dist
  • python310Packages.sshfs
  • python310Packages.sshfs.dist
  • python311Packages.aioasuswrt
  • python311Packages.aioasuswrt.dist
  • python311Packages.asyncssh
  • python311Packages.asyncssh.dist
  • python311Packages.dvc
  • python311Packages.dvc-ssh
  • python311Packages.dvc-ssh.dist
  • python311Packages.dvc.dist
  • python311Packages.dvclive
  • python311Packages.dvclive.dist
  • python311Packages.libnacl
  • python311Packages.libnacl.dist
  • python311Packages.scmrepo
  • python311Packages.scmrepo.dist
  • python311Packages.sshfs
  • python311Packages.sshfs.dist
  • tribler

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 29, 2023
@wegank
Copy link
Member

wegank commented Oct 12, 2023

@ofborg build python3Packages.libnacl python3Packages.libnacl.passthru.tests

fabaff
fabaff approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit a97d85f into NixOS:master Oct 13, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff approved these changes

@marsam marsam marsam approved these changes

@xvapx xvapx Awaiting requested review from xvapx

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pbsds @fabaff @wegank @marsam @delroth