Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.primer3: enable tests #255260

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Conversation

doronbehar
Copy link
Contributor

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ppom0
Copy link
Contributor

ppom0 commented Sep 15, 2023

LGTM

@doronbehar
Copy link
Contributor Author

Let's give a bit of time for upstream to respond on the issue I just opened there (libnano/primer3-py#120).

@doronbehar
Copy link
Contributor Author

Thanks to upstream's help at libnano/primer3-py#120, I think this should be ready. I'll wait for @fabaff 's approval for a few days, and if they won't reply I'll merge this.

@doronbehar doronbehar changed the title python3.pkgs.primer3: better explain why tests are disabled python3.pkgs.primer3: enable tests Sep 16, 2023
@doronbehar doronbehar merged commit 591a09e into NixOS:master Sep 30, 2023
@doronbehar doronbehar deleted the pkg/primer branch September 30, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants