Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blisp: unstable-2023-06-03 -> 0.0.4 #254311

Merged
merged 1 commit into from
Sep 10, 2023
Merged

blisp: unstable-2023-06-03 -> 0.0.4 #254311

merged 1 commit into from
Sep 10, 2023

Conversation

bdd
Copy link
Contributor

@bdd bdd commented Sep 9, 2023

  • Slightly change the description to be...more descriptive.
  • Add a passthru test.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from moni-dz September 9, 2023 23:56
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 9, 2023
@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Sep 10, 2023
nagy
nagy reviewed Sep 10, 2023
View reviewed changes
pkgs/development/embedded/blisp/default.nix Outdated Show resolved Hide resolved
pkgs/development/embedded/blisp/default.nix Outdated Show resolved Hide resolved
@bdd bdd requested a review from nagy September 10, 2023 17:34
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 10, 2023
@ofborg ofborg bot requested a review from moni-dz September 10, 2023 18:44
nagy
nagy suggested changes Sep 10, 2023
View reviewed changes
pkgs/development/embedded/blisp/default.nix Outdated Show resolved Hide resolved
pkgs/development/embedded/blisp/default.nix Show resolved Hide resolved
@bdd bdd requested a review from nagy September 10, 2023 20:25
@bdd
blisp: unstable-2023-06-03 -> 0.0.4
110bc35 
- Slightly change the description to be...more descriptive.
- Add a passthru test.
@delroth delroth added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Sep 10, 2023
@wegank wegank merged commit 4ac0fc0 into NixOS:master Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagy nagy nagy approved these changes

@moni-dz moni-dz Awaiting requested review from moni-dz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bdd @nagy @moni-dz @delroth @wegank