win-dll-links: also copy dll from dependencies #252459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I'm not a good person for Windows stuff.) |
|
@vcunat I have tested the changes and DLLs get copied to output directory. I have also tested to run with wine64 and executable can run being able to find all dependencies. |
|
|
Artturin
reviewed
Aug 31, 2023
Artturin
force-pushed
the
win-dll-link
branch
2 times, most recently
from
f4a6080 to
5551a5b
Compare
Fixes running `pkgsCross.mingwW64._7zz` in wine. Fixes issue 38451 ``` tree result/bin result/bin ├── 7zz.exe └── mcfgthread-12.dll -> ../../wmgj476qjfw26f9aij1d64lxrjfv6kk0-mcfgthreads-x86_64-w64-mingw32-git/bin/mcfgthread-12.dll ``` Co-authored-by: marius david <[email protected]>
vcunat
added a commit
that referenced
this pull request
Sep 1, 2023
...into staging-next. It's a topologically earlier remerge.
This was referenced Sep 5, 2023
|
Successfully created backport PR for |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Copies Windows dependencies. Refactored changes from #227818. DLLs get copied to output path and are correctly symlinked. Tested with wine64 that application can run correctly and link properly.
Fixes #38451
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)