Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: set also sys._base_executable as venv uses it #250935

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

python: set also sys._base_executable as venv uses it #250935

wants to merge 1 commit into from

Conversation

domenkozar
Copy link
Member

https://github.com/python/cpython/blob/31b61d19abcc63aa28625a31ed75411948fc1e7e/Lib/venv/__init__.py#L130

Otherwise ${python.buildEnv {..}.interpreter} -m venv copies the wrong python executable.

@domenkozar domenkozar requested a review from FRidh as a code owner August 23, 2023 09:21
@domenkozar domenkozar force-pushed the python-buildEnv-venv branch from 923fd40 to 08a3497 Compare August 23, 2023 09:31
@domenkozar domenkozar mentioned this pull request Aug 23, 2023
Open
@FRidh
Copy link
Member

FRidh commented Aug 23, 2023

Please check python3.tests and the attribute for all other interpreters as well.

@FRidh
Copy link
Member

FRidh commented Aug 23, 2023

If needed we should have a test for this as well.

@mauricege mauricege mentioned this pull request Dec 7, 2023
Closed
7 tasks
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 5, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 5, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@domenkozar @FRidh @wegank