yaml-cpp: 0.7.0 -> 0.8.0 #249947
Merged
yaml-cpp: 0.7.0 -> 0.8.0 #249947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OPNA2608
requested changes
Aug 18, 2023
|
Breaks Full report: Result of 4 packages marked as broken and skipped:
17 packages failed to build:
73 packages built:
|
|
I think we should wait for AcademySoftwareFoundation/OpenColorIO#1823 then. |
tobim
force-pushed
the
pkgs/yaml-cpp-0.8.0
branch
from
b354509 to
095a4c3
Compare
tobim
force-pushed
the
pkgs/yaml-cpp-0.8.0
branch
3 times, most recently
from
208984a to
562004f
Compare
tobim
force-pushed
the
pkgs/yaml-cpp-0.8.0
branch
from
562004f to
b4b6ff3
Compare
|
Result of 1 package marked as broken and skipped:
13 packages failed to build:
80 packages built:
|
|
krita, osl, and olive-editor are now fixed. |
ofborg
bot
requested review from
abbradar,
cillianderoiste,
nek0 and
sifmelcara
|
Mir: Failing on Hydra after recent staging merge. Looks to be canonical/mir#3019, so unrelated. sysdig on hardened kernels: Failing since checks date 2022-04-17 according to Hydra, wow. Very likely unrelated. I'll run a nixpkgs-review tonight to verify. |
|
Result of 1 package marked as broken and skipped:
10 packages failed to build:
83 packages built:
|
|
|
tobim
force-pushed
the
pkgs/yaml-cpp-0.8.0
branch
from
4b268fd to
87eb829
Compare
|
Result of 15 packages marked as broken and skipped:
2 packages failed to build:
12 packages built:
|
|
Sorry for the review delay, should have more free time for this now. Re-running the review to test everything. Regarding the changes:
|
tobim
force-pushed
the
pkgs/yaml-cpp-0.8.0
branch
from
87eb829 to
e7ea41e
Compare
OpenColorIO checks which extensions are supported by the CPU at runtime, so it should actually be fine to enable all of them. The interface for that is defined in https://github.com/AcademySoftwareFoundation/OpenColorIO/blob/main/src/OpenColorIO/CPUInfo.h. |
Is there a reason why we disabled all the AVX ones then? Or just uncertainty about how this worked? I guess for the ( |
|
Result of 1 package marked as broken and skipped:
13 packages failed to build:
86 packages built:
Checked failure reasons, saw nothing that would be caused by this PR as you mentioned. Checked |
Frankly I forgot to take it out again. I only looked in detail after setting the flags. I can remove them in a few hours. |
tobim
force-pushed
the
pkgs/yaml-cpp-0.8.0
branch
from
e7ea41e to
b5cd2e5
Compare
OPNA2608
approved these changes
Nov 4, 2023
There was a problem hiding this comment.
Re-checked opencolorio cus that's the only change since last nixpkgs-review (already GC'd that one, and I don't wanna sit through all the big rebuilds again…), still builds. LGTM?
Thanks for working on this basically as soon as the new version released, much appreciated!
OPNA2608
added
the
12.approvals: 1
13 tasks
| # https://github.com/olive-editor/olive/issues/2200 | ||
| patchPhase = '' |
There was a problem hiding this comment.
that's good 👍🏼 we should never overwrite patchPhase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
https://github.com/jbeder/yaml-cpp/releases/tag/0.8.0
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)