libsForQt5.qmltermwidget: Adopt, cleanups, make Lomiri-compatible #245778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2498 |
10 tasks
- Clarify license - Replace INSTALL_ROOT with proper $$PREFIX usage - Minor style stuff
So we can use it for lomiri-terminal-app
OPNA2608
force-pushed
the
fix/qmltermwidget-lomiri
branch
from
50bacb7 to
cd28d78
Compare
OPNA2608
changed the title
ofborg
bot
added
the
11.by: package-maintainer
Sigmanificient
added
the
0.kind: package adoption
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Working towards #99090.
lomiri-terminal-appneeds aqmltermwidgetthat exposes certain interfaces, andqmltermwidgetwas recently orphaned. This PR assigns the package to me, does some small cleanups, and pulls in the patches required to make it Lomiri-compatible.INSTALL_ROOTas a substitute for using thePREFIX, not what that variable is for (it works likeDESTDIR)lomiri-terminal-appto use this version ofqmltermwidgetThings done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)