Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux_6_3: drop as EOL #244883

Merged
merged 1 commit into from
Jul 28, 2023
Merged

linux_6_3: drop as EOL #244883

merged 1 commit into from
Jul 28, 2023

Conversation

fabianhjr
Copy link
Member

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@fabianhjr fabianhjr requested a review from RaitoBezarius as a code owner July 22, 2023 18:56
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: kernel The Linux kernel labels Jul 22, 2023
@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 22, 2023
@fabianhjr fabianhjr marked this pull request as draft July 22, 2023 20:32
@RaitoBezarius RaitoBezarius mentioned this pull request Jul 26, 2023
Closed
12 tasks
@RaitoBezarius RaitoBezarius marked this pull request as ready for review July 27, 2023 16:07
RaitoBezarius
RaitoBezarius approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@RaitoBezarius RaitoBezarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to go. We don't need to wait on ZFS anymore.

@fabianhjr
Copy link
Member Author

To confirm, leaving the 6.3 → 6.1 change?

@RaitoBezarius
Copy link
Member

To confirm, leaving the 6.3 → 6.1 change?

Correct. Downgrade is fine.

@fabianhjr fabianhjr requested review from Mic92, K900, alyssais and Ma27 July 28, 2023 06:36
@RaitoBezarius RaitoBezarius merged commit 3ac8c61 into NixOS:master Jul 28, 2023
@fabianhjr fabianhjr deleted the linux_6_3_eol branch July 28, 2023 20:59
@Ma27
Copy link
Member

Ma27 commented Jul 29, 2023

These are also EOL on 23.05, so we should remove them there as well.

@github-actions
Copy link
Contributor

Backport failed for release-23.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-23.05
git worktree add -d .worktree/backport-244883-to-release-23.05 origin/release-23.05
cd .worktree/backport-244883-to-release-23.05
git checkout -b backport-244883-to-release-23.05
ancref=$(git merge-base 7ed1b2bc030535e4d7e5eeb2b0aafbe4842b8689 ffba10cd9a48c9736fde33d4d145eea43ddd532b)
git cherry-pick -x $ancref..ffba10cd9a48c9736fde33d4d145eea43ddd532b

@fabianhjr
Copy link
Member Author

Hi, will make the cherry-pick manually. Thanks for the heads up will do. :3

@Ma27
Copy link
Member

Ma27 commented Jul 29, 2023

Thanks for taking care of that! Was about to do it tomorrow otherwise :)

@fabianhjr fabianhjr mentioned this pull request Jul 29, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shawn8901 Shawn8901 Shawn8901 left review comments

@RaitoBezarius RaitoBezarius RaitoBezarius approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

@K900 K900 Awaiting requested review from K900

@alyssais alyssais Awaiting requested review from alyssais

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
6.topic: kernel The Linux kernel 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fabianhjr @RaitoBezarius @Ma27 @Shawn8901