module system: Clean up and improve an error message #242812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byName is not an abstraction. This is the first commit in a series that refactors it away.
This is a non-trivial refactor that slightly changes the semantics of the internal definition lists. Whereas previously only individual list items would trigger the exception, now the error is promoted to the whole list. This is mostly ok, because we compute the value, it is wrong to ignore a definition. However, we don't always compute the value. For instance `readOnly` only needs to count definitions. That won't be possible anymore when the error is raised for one of the items. As a consequence, an error will be raised for the errant definition instead of the number of definitions.
github-actions
bot
added
6.topic: module system
12 tasks
roberth
force-pushed
the
modules-remove-byName-obfuscation
branch
from
5505bdb to
8014460
Compare
roberth
commented
Jul 11, 2023
| checkedConfigs = | ||
| assert | ||
| lib.all | ||
| (c: |
There was a problem hiding this comment.
This is called module in the other functions, which seems like a really bad name for something that's only remotely module-like.
I've scoped out renaming more of it because I think we should first get our definitions straight and then rename it everywhere. Meanwhile, I can't approve of module so I just called it c for config.
ofborg
bot
added
10.rebuild-darwin: 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This is mostly about refactoring away
byNamewhich was a non-abstraction.Most of the commits are the small refactoring steps, separated out so they can be followed and checked.
The only commits that aren't pure refactoring are the ones titled
These changes were motivated by #242339 (comment)
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)