-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sbcl.pkgs: update to Quicklisp dist from June 2023 #238790
Conversation
5e4dd15
to
5a1f380
Compare
@ofborg build nyxt |
#235095 updates some packages manually to build the new version nyxt. Should we revert these updates and apply the new ones in quicklisp? |
Re: Nyxt deps: I guess if Quicklisp has updated at least as far, we can try dropping the overrides (and see if Nyxt is happy). But this can be done separately. |
Result of 2 packages failed to build:
301 packages built:
Out of the package that failed
I debugged around a bit and found the culprit, this commit here for diff --git a/src/docs.lisp b/src/docs.lisp
index 49046ae..3265cf3 100644
--- a/src/docs.lisp
+++ b/src/docs.lisp
@@ -14,7 +14,7 @@
(40ants-doc:defsection @manual
(:title "Tar"
:export nil
- :package-symbol (find-package :tar))
+ :package :tar)
#.(uiop:read-file-string (asdf:system-relative-pathname :tar "README.md"))
(@tar 40ants-doc/locatives:section)
(@tar-simple-extract 40ants-doc/locatives:section)
@@ -24,7 +24,7 @@
(40ants-doc:defsection @tar-simple-extract
(:title "Simple Extraction"
:export nil
- :package-symbol (find-package :tar-simple-extract))
+ :package :tar-simple-extract)
"This section describes the support for simple extraction to the filesystem."
(simple-extract-archive 40ants-doc/locatives:function)
(@tar-simple-extract-conditions 40ants-doc/locatives:section))
@@ -32,7 +32,7 @@
(40ants-doc:defsection @tar-simple-extract-conditions
(:title "Simple Extraction Conditions"
:export nil
- :package-symbol (find-package :tar-simple-extract))
+ :package :tar-simple-extract)
"This section describes the conditions that can occur during
SIMPLE-EXTRACT-ARCHIVE."
(extraction-error 40ants-doc/locatives:class)
@@ -56,7 +56,7 @@ SIMPLE-EXTRACT-ARCHIVE."
(40ants-doc:defsection @tar-extract
(:title "Extraction"
:export nil
- :package-symbol (find-package :tar-extract))
+ :package :tar-extract)
"This section describes the support for non-portable extraction to the
filesystem."
(extract-archive 40ants-doc/locatives:function)
@@ -65,7 +65,7 @@ filesystem."
(40ants-doc:defsection @tar-extract-conditions
(:title "Extraction Conditions"
:export nil
- :package-symbol (find-package :tar-extract))
+ :package :tar-extract)
"This section describes the conditions that can occur during
EXTRACT-ARCHIVE."
(extraction-error 40ants-doc/locatives:class)
@@ -101,7 +101,7 @@ EXTRACT-ARCHIVE."
(40ants-doc:defsection @tar-create
(:title "Create"
:export nil
- :package-symbol (find-package :tar-create))
+ :package :tar-create)
"This section describes the support for non-portable creation of archives
from the filesystem."
(create-archive 40ants-doc/locatives:function))
@@ -109,7 +109,7 @@ from the filesystem."
(40ants-doc:defsection @tar
(:title "Tar"
:export nil
- :package-symbol (find-package :tar))
+ :package :tar)
"This section describes the high level tar archive support."
(@tar-archives 40ants-doc/locatives:section)
(@tar-entries 40ants-doc/locatives:section)
@@ -118,7 +118,7 @@ from the filesystem."
(40ants-doc:defsection @tar-archives
(:title "Tar Archives"
:export nil
- :package-symbol (find-package :tar))
+ :package :tar)
(tar:archive 40ants-doc/locatives:class)
(tar:gnu-archive 40ants-doc/locatives:class)
(tar:pax-archive 40ants-doc/locatives:class)
@@ -132,7 +132,7 @@ from the filesystem."
(40ants-doc:defsection @tar-entries
(:title "Tar Entries"
:export nil
- :package-symbol (find-package :tar))
+ :package :tar)
"This section describes the various entry types and how to read/write them
from/to an archive."
@@ -168,7 +168,7 @@ from the filesystem."
(40ants-doc:defsection @tar-conditions
(:title "Tar Conditions"
:export nil
- :package-symbol (find-package :tar))
+ :package :tar)
"This section describes the various conditions and restarts in the tar
system."
(tar:tar-condition 40ants-doc/locatives:class) |
@ofborg build sbcl.pkgs.tar |
Out-of-quicklisp version that was manually specified in packages.nix stopped building after Quicklisp dist bump, because of a change in one of its dependencies. Switching to using the one imported straight from Quicklisp, in imported.nix. See NixOS#238790 (comment)
Doesn't work with the new webkitgtk_6_0
8d557f4
to
ec7dea4
Compare
Description of changes
Ran
ql-import.lisp
Upstream announcement: http://blog.quicklisp.org/2023/06/june-2023-quicklisp-dist-update-now.html
Notably:
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)