antlr4_13: init at 4.13.0 and set as default #238543
Conversation
|
Result of 2 packages failed to build:
55 packages built:
|
ofborg
bot
added
8.has: package (new)
| nativeBuildInputs = [ | ||
| setuptools | ||
| ]; | ||
|
|
||
| # in 4.9, test was renamed to tests |
There was a problem hiding this comment.
I know this is not strictly related to your patch. Could you explain why is this cd test* not cd tests? Is this expression meant to be compatible with multiple antlr versions? If not, the asterisk could be removed.
There was a problem hiding this comment.
I think the comment pretty much has explained it, so the folder is named test pre 4.9, but tests since 4.9.
There was a problem hiding this comment.
I think the comment pretty much has explained it, so the folder is named
testpre 4.9, buttestssince 4.9.
@NickCao what I tried to propose, is that perhaps because this expression is used with only a single antlr4.runtime.cpp.src, the asterisk could be removed.
There was a problem hiding this comment.
But it can (and is) used with other versions of antlr, see pkgs/servers/baserow/default.nix for example.
There was a problem hiding this comment.
But it can (and is) used with other versions of antlr, see
pkgs/servers/baserow/default.nixfor example.
I see, than in that case, let's write this detail in the comment, something like:
| # in 4.9, test was renamed to tests | |
| # We use an asterisk because this expression is used also for old antlr | |
| # versions, where there the tests directory is `tests` and not `test`. See | |
| # e.g in package `baserow`. |
|
Looks pretty good so far! I very much appreciate PRs that make the latest version the default version. Could you please run another |
NickCao
force-pushed
the
antlr
branch
2 times, most recently
from
4e5a5ba to
b80aa60
Compare
|
Result of 4 packages failed to build:
72 packages built:
|
|
fairseq is broken on master: https://hydra.nixos.org/eval/1798993?filter=fairseq |
|
Good to merge when CI is green. |
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)