Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clisp: 2.49 -> 2.50pre2023-01-12; 2.50pre20171114 -> remove #236927

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

tobim
Copy link
Contributor

@tobim tobim commented Jun 9, 2023

Description of changes

Update clisp to new active repo at https://gitlab.com/gnu-clisp/clisp.
Using the latest commit on the 2.50 branch as version.
This goes towards #87909.

I also added darwin to the platforms again, but can't test it. Help would be greatly appreciated!

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@tobim
Copy link
Contributor Author

tobim commented Jun 9, 2023

Result of nixpkgs-review run on x86_64-linux 1

25 packages built:
  • advi
  • apostrophe
  • avrdude
  • avrdudess
  • blahtexml
  • blahtexml.doc
  • bluespec
  • bluespec.doc
  • clisp
  • klipper-firmware
  • klipper-flash
  • ne
  • nuweb
  • opentx
  • qmk
  • qmk.dist
  • texlive.combined.scheme-full
  • texlive.combined.scheme-medium
  • tinygo
  • xyce
  • xyce-parallel
  • xyce-parallel.doc
  • xyce.doc
  • yosys-bluespec
  • zettlr

@tobim tobim force-pushed the pkgs/clisp-update branch from 49a02eb to 79589c2 Compare June 10, 2023 09:06
@ofborg ofborg bot requested a review from nagy June 10, 2023 09:23
@7c6f434c
Copy link
Member

Looks like (at least) OpenGL part of CLX does not build on macOS? Although this probably means that the main console part does build.

Separately: if you consider this a replacement for the main line, maybe fix the error of my ways six years ago and use 2.49-unstable-2023-01-09 instead of a 2.50pre-based version? (Using past versions instead of prediceted future ones for snapshots without upstream versions, as has been argued in the last couple of years)

@tobim tobim changed the title clisp: 2.49 -> 2.50pre2023-01-09; 2.50pre20171114 -> remove clisp: 2.49 -> 2.50pre2023-01-12; 2.50pre20171114 -> remove Sep 26, 2023
@tobim
Copy link
Contributor Author

tobim commented Sep 26, 2023

Looks like (at least) OpenGL part of CLX does not build on macOS? Although this probably means that the main console part does build.

I finally got temporary access to a darwin machine and was able to fix the build. Please check the latest commit.

Separately: if you consider this a replacement for the main line, maybe fix the error of my ways six years ago and use 2.49-unstable-2023-01-09 instead of a 2.50pre-based version? (Using past versions instead of prediceted future ones for snapshots without upstream versions, as has been argued in the last couple of years)

In this case we're building of the 2.50 branch though, so I'd argue that naming is more correct than 2.49-unstable.

@tobim
Copy link
Contributor Author

tobim commented Sep 26, 2023

Result of nixpkgs-review pr 236927 run on aarch64-darwin 1

4 packages marked as broken and skipped:
  • xyce
  • xyce-parallel
  • xyce-parallel.doc
  • xyce.doc
8 packages built:
  • advi
  • blahtexml
  • blahtexml.doc
  • clisp
  • ne
  • nuweb
  • texlive.combined.scheme-full
  • texlive.combined.scheme-medium

@tobim
Copy link
Contributor Author

tobim commented Sep 26, 2023

Result of nixpkgs-review pr 236927 run on x86_64-linux 1

2 packages failed to build:
  • klipper-firmware
  • klipper-flash
24 packages built:
  • advi
  • apostrophe
  • avrdude
  • avrdudess
  • blahtexml
  • blahtexml.doc
  • bluespec
  • bluespec.doc
  • clisp
  • ne
  • nuweb
  • opentx
  • qmk
  • qmk.dist
  • texlive.combined.scheme-full
  • texlive.combined.scheme-medium
  • tinygo
  • xyce
  • xyce-parallel
  • xyce-parallel.doc
  • xyce.doc
  • yosys-bluespec
  • zettlr
  • zettlr-beta

klipper-firmware is failing on hydra with the same error: https://hydra.nixos.org/eval/1799650?filter=klipper-firmware&compare=1799628&full=

@7c6f434c 7c6f434c merged commit 81aa88d into NixOS:master Sep 26, 2023
@7c6f434c
Copy link
Member

For upstreams who do more releases, I would actually expect the branch to be renamed to 3.0 or 2.49.1 like nothing has happened, but yeah probably clisp will do the simplest thing available with releases (if at all)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants