nixos/syncthing: Remove unnecessary patch note

[mart-w]

The breaking change mentioned in this patch note has been reverted for now, see #226088.

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[Lassulus]

I woulf prefer merging #233386 over reverting this, since we wanted to continue with it in unstable anyway.

[mart-w]

Even if it were to merge the change now, it’s a breaking change, so it wouldn’t make it into stable before 23.11 anyway, correct? So it still probably shouldn’t be in the 23.05 patch notes. Should we instead move it to the 23.11 patch notes?

[Lassulus]

yeah thats right, not sure if we need to backport this also

[github-actions]

Successfully created backport PR for release-23.05:

• [Backport release-23.05] nixos/syncthing: Remove unnecessary patch note #235768