Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/gotosocial: init #232862

Merged
merged 2 commits into from
Jun 13, 2023
Merged

nixos/gotosocial: init #232862

merged 2 commits into from
Jun 13, 2023

Conversation

misuzu
Copy link
Contributor

@misuzu misuzu commented May 19, 2023 •
edited
Loading

Description of changes

https://gotosocial.org/
https://github.com/superseriousbusiness/gotosocial

Based on #202110

cc @f0x52

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels May 19, 2023
@misuzu misuzu force-pushed the gotosocial-init branch from 0fff8f0 to 4e17680 Compare May 19, 2023 17:18
@figsoda
Copy link
Member

figsoda commented May 19, 2023

@ofborg eval

@misuzu misuzu force-pushed the gotosocial-init branch 5 times, most recently from 27a520d to 1d774d3 Compare May 19, 2023 18:18
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels May 19, 2023
@misuzu misuzu force-pushed the gotosocial-init branch from 1d774d3 to 76e0844 Compare May 20, 2023 08:04
@misuzu misuzu mentioned this pull request May 20, 2023
Closed
17 tasks
pbsds
pbsds requested changes May 20, 2023
View reviewed changes
Copy link
Member

@pbsds pbsds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

pkgs/servers/gotosocial/default.nix Outdated Show resolved Hide resolved
@misuzu misuzu force-pushed the gotosocial-init branch from 76e0844 to b7232f3 Compare May 20, 2023 10:07
@misuzu misuzu requested a review from SuperSandro2000 May 20, 2023 11:18
SuperSandro2000
SuperSandro2000 reviewed May 22, 2023
View reviewed changes
pkgs/servers/gotosocial/default.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/gotosocial.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/gotosocial.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/gotosocial.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/gotosocial.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/gotosocial.md Outdated Show resolved Hide resolved
@misuzu misuzu force-pushed the gotosocial-init branch 2 times, most recently from d2de19c to 2191602 Compare May 23, 2023 06:47
@f0x52
Copy link
Contributor

f0x52 commented May 23, 2023

Nice work! Some notes:

@misuzu misuzu force-pushed the gotosocial-init branch from 2191602 to cc21d16 Compare May 23, 2023 16:41
@misuzu
Copy link
Contributor Author

misuzu commented May 23, 2023 •
edited
Loading

  • I think it would be good to explicitly mention that the host config cannot be changed after running once, similar to matrix-synapse

Added a note and an assertion, thanks!

That would be very ugly, I think it's better to wait for #210814 to be merged first.

@misuzu misuzu force-pushed the gotosocial-init branch from cc21d16 to 7765ff6 Compare May 23, 2023 16:54
SuperSandro2000
SuperSandro2000 reviewed May 30, 2023
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase otherwise LGTM

@misuzu misuzu force-pushed the gotosocial-init branch 2 times, most recently from bd85f8d to 61fdf0a Compare May 30, 2023 12:32
@misuzu misuzu requested a review from SuperSandro2000 May 30, 2023 13:52
SuperSandro2000
SuperSandro2000 approved these changes Jun 4, 2023
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do another rebase

misuzu and others added 2 commits June 5, 2023 09:06
@misuzu @pbsds
gotosocial: init at 0.9.0
f0fb246 
Co-authored-by: Peder Bergebakken Sundt <[email protected]>
@misuzu @pbsds
nixos/gotosocial: init
45ffb33 
Co-authored-by: Peder Bergebakken Sundt <[email protected]>
@misuzu misuzu force-pushed the gotosocial-init branch from 61fdf0a to 45ffb33 Compare June 5, 2023 06:08
@misuzu misuzu requested a review from SuperSandro2000 June 6, 2023 16:11
@SuperSandro2000 SuperSandro2000 merged commit 9183a72 into NixOS:master Jun 13, 2023
@misuzu misuzu deleted the gotosocial-init branch July 14, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbsds pbsds pbsds approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@misuzu @figsoda @f0x52 @pbsds @SuperSandro2000