Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 22.11] wasm-bindgen-cli: 0.2.83 -> 0.2.84 #228754

Merged
merged 1 commit into from
Apr 29, 2023

Conversation

lelgenio
Copy link
Contributor

This realease fixes rustwasm/wasm-bindgen#2776 which makes it impossible to use trunk inside derivations. It also gives a good error message if a similar issue is to ever occur again.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

(cherry picked from commit fe77668)
@NickCao
Copy link
Member

NickCao commented Apr 29, 2023

Result of nixpkgs-review pr 228754 run on x86_64-linux 1

1 package built:
  • wasm-bindgen-cli

@NickCao NickCao merged commit 60404ce into NixOS:release-22.11 Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants