-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lldap: init at 0.4.3; nixos/lldap: init; nixosTests.lldap: init #227916
Conversation
Very nice. Extractig frontend from amd64 package seems a little hacky, I have implemented a basic nixos module for lldap for my own use, so maybe we can add it together with the package? |
For what it's worth, nixpkgs/pkgs/servers/kanidm/default.nix Lines 65 to 70 in 6577af6
Regarding your nixos module: There are a few things I would do different at first glance (e.g. I guess we could also build a simple VM test 🤔 |
d43135f
to
69870e9
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2135 |
I added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Thanks to everyone for doing this.
@ofborg test lldap |
Result of 2 packages blacklisted:
1 package built:
|
Co-authored-by: LongerHV <[email protected]>
Description of changes
https://github.com/lldap/lldap
Package request: #142275
Supersedes previous attempt: #197362
Unfortunately, we have to grab the wasm frontend from the upstream release tarball, as the wasm32-unknown-unknown rustc target isn't available in nixpkgs yet.
Tracking issue: #89426
I made sure the frontend works and looks as expected, and successfully ran the following very simple ldap query:
(default
admin
password ispassword
)Not sure if I will actually end up replacing openldap setups with this.
I just saw this project, checked if it's packaged, noticed it isn't, saw the package request and past attempts and then wanted to try packaging it myself :)
If anyone wants to be added to
meta.maintainers
, let me know!PS: There is also https://github.com/kanidm/kanidm (in nixpkgs) which provides a ldap read-only interface, if that's all one needs.
resolves #142275, closes #197362
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)