Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prisma-engines: 4.11.0 -> 4.12.0 #223700

Merged
merged 3 commits into from
Apr 1, 2023
Merged

Conversation

ivan
Copy link
Member

@ivan ivan commented Mar 29, 2023

Description of changes

prisma/prisma-engines@4.11.0...4.12.0

https://github.com/prisma/prisma/releases/tag/4.12.0

I removed "-p" "introspection-core" because introspection-core is gone in prisma-engines.

I copied Cargo.lock from [email protected].

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

cc maintainers @Pamplemousse @pimeys @tomhoule

@tomhoule
Copy link
Contributor

It doesn't relate directly to this PR, but I don't understand why we have a committed Cargo.lock in nixpkgs now, it wasn't the case until very recently and I didn't get a notification when that happened. Git blame points to 0f2c778 but that's not super helpful. Does anybody have more context?

Otherwise the PR looks good to me. You might want to update nodePackages.prisma too.

@tomhoule
Copy link
Contributor

Ok found when and how that happened: #221716

@lucasew
Copy link
Contributor

lucasew commented Mar 29, 2023

Result of nixpkgs-review pr 223700 run on x86_64-linux 1

1 package built:
  • prisma-engines

@pimeys
Copy link
Contributor

pimeys commented Mar 30, 2023

Hey, @ivan! Thanks for this, we need more maintainers.

One thing missing is that by just updating prisma-engines, you are breaking nodePackages.prisma. You can try out building it, which will give you an error of a wrong sha sum.

Just update the new sum, rebuild and create two commits: one updating prisma-engines and another nodePackages.prisma.

@ivan
Copy link
Member Author

ivan commented Mar 30, 2023

@pimeys thanks for the review. I updated the hash for nodePackages.prisma now.

@lucasew
Copy link
Contributor

lucasew commented Mar 30, 2023

Result of nixpkgs-review pr 223700 run on x86_64-linux 1

1 package built:
  • prisma-engines

@ofborg ofborg bot requested review from pimeys and removed request for pimeys March 30, 2023 09:57
@marsam marsam merged commit a47ef61 into NixOS:master Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants