Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODEOWNERS: Add OCaml maintainers #221307

Merged
merged 2 commits into from
Mar 18, 2023

Conversation

ulrikstrid
Copy link
Member

@ulrikstrid ulrikstrid commented Mar 15, 2023

Description of changes

Other people that might want to be included:

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ulrikstrid ulrikstrid requested a review from edolstra as a code owner March 15, 2023 11:33
@ulrikstrid ulrikstrid force-pushed the ulrikstrid--ocaml-team branch 2 times, most recently from b62acd2 to be991ba Compare March 15, 2023 11:37
@superherointj
Copy link
Contributor

Thanks, this is long overdue. Feel free to add me.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 15, 2023
@sternenseemann
Copy link
Member

Sorry, I'll have to pass, have my time tied up with Haskell well enough already.

@vbgl
Copy link
Contributor

vbgl commented Mar 15, 2023

Can someone please elaborate (or link to relevant documentation) what’s the meaning of the “team”? Thanks.

@superherointj
Copy link
Contributor

superherointj commented Mar 15, 2023

Can someone please elaborate (or link to relevant documentation) what’s the meaning of the “team”? Thanks.

https://github.com/NixOS/nixpkgs/blob/master/doc/contributing/reviewing-contributions.chapter.md#maintainer-teams-reviewing-contributions-maintainer-teams

create a new maintainer team in maintainers/team-list.nix when a group is collectively responsible for a collection of packages.

Indexes active maintainers of a domain.
Allows to quickly reference a collective, for:

  • notifying changes (as in CODEOWNERS)
  • requesting reviews
  • referencing maintainers:

    meta.maintainers = with maintainers; [ ] ++ teams.ocaml.members;

  • on @mentions (like: @nixos/ocaml for the entire team) in any comment, issue, or pull request.

References:

.github/CODEOWNERS Outdated Show resolved Hide resolved
@ulrikstrid ulrikstrid force-pushed the ulrikstrid--ocaml-team branch 2 times, most recently from fb81230 to 212f1b0 Compare March 15, 2023 16:38
@ulrikstrid ulrikstrid force-pushed the ulrikstrid--ocaml-team branch from 1e6a17f to c09eebb Compare March 17, 2023 19:32
Co-authored-by: superherointj <[email protected]>
@ulrikstrid ulrikstrid force-pushed the ulrikstrid--ocaml-team branch from c09eebb to b157975 Compare March 17, 2023 19:34
@ulrikstrid ulrikstrid changed the title Add OCaml team and CODEOWNERS CODEOWNERS: Add OCaml maintainers Mar 17, 2023
@ulrikstrid
Copy link
Member Author

Changed to scope to just add people that wants to be notified on OCaml changes to CODEOWNERS. Anyone else mentioned in this PR can feel free to add themselves

@superherointj
Copy link
Contributor

@ofborg eval

@romildo
Copy link
Contributor

romildo commented Mar 17, 2023

Feel free to add me.

.github/CODEOWNERS Outdated Show resolved Hide resolved
@superherointj superherointj merged commit f6bbab1 into NixOS:master Mar 18, 2023
@ulrikstrid ulrikstrid deleted the ulrikstrid--ocaml-team branch March 18, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: policy discussion 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants