pgadmin: pin flask-babel to fix build failure #214311
Conversation
pgadmin needs an older version of flask-security-too, which is incompatible with the update of flask-babel. This commit pins the version. Signed-off-by: Florian Brandes <[email protected]>
ofborg
bot
added
11.by: package-maintainer
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package built:
|
|
@ofborg build pgadmin4 pgadmin4.passthru.tests |
|
Result of 1 package failed to build:
|
Did pgadmin work on aarch64-darwin before? I unfortunately have no way to test that |
|
The darwin failures were propagated from pyodbc, so false alarm. |
|
@ofborg test pgadmin4-standalone |
|
|
|
Where do you see that? |
Did an local |
|
ah, yeah. nixpkgs/nixos/tests/pgadmin4.nix Lines 4 to 16 in f782da6 |
|
A hint: for running postgresql server at test time, we now have |
Cool. I'll have a look |
| }; | ||
| nativeBuildInputs = [ ]; | ||
| format = "setuptools"; | ||
| outputs = [ "out" ]; |
There was a problem hiding this comment.
What was the error before you overwrite outputs?
There was a problem hiding this comment.
Well, due to the update of flask-babel there is now:
outputs = [
"out"
"doc"
];
and the override does not prove doc.
The error message is:
error: builder for '/nix/store/pz3rhdsvc0m0s8in3pqafvbifblbimq4-python3.10-flask-babel-2.0.0.drv' failed to produce output path for output 'doc' at '/nix/store/pz3rhdsvc0m0s8in3pqafvbifblbimq4-python3.10-flask-babel-2.0.0.drv'
There was a problem hiding this comment.
Didn't know that, then it is necessary.
Description of changes
pgadmin needs an older version of flask-security-too, which is incompatible with the update of flask-babel from #211654
This commit pins the version.
Note:
nixpkgs-reviewhangs right now. Will test later (But shouldn't have any impact. No packages depend onpgadmin)Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes