Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nscd: use nsncd by default #214153

Merged
merged 1 commit into from
Feb 2, 2023
Merged

nixos/nscd: use nsncd by default #214153

merged 1 commit into from
Feb 2, 2023

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Feb 2, 2023

As announced in the NixOS 22.11 release notes, 23.05 will switch NixOS to using nsncd (a non-caching reimplementation in Rust) as NSS lookup dispatcher, instead of the buggy and deprecated glibc-provided nscd.

If you need to switch back, set services.nscd.enableNsncd = false, but please open an issue in nixpkgs so your issue can be fixed.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@flokli
nixos/nscd: use nsncd by default
fbfe290 
As announced in the NixOS 22.11 release notes, 23.05 will switch NixOS
to using nsncd (a non-caching reimplementation in Rust) as NSS lookup
dispatcher, instead of the buggy and deprecated glibc-provided nscd.

If you need to switch back, set `services.nscd.enableNsncd = false`, but
please open an issue in nixpkgs so your issue can be fixed.
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 2, 2023
NickCao
NickCao approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have been using nsncd on all my systems since its introduction, rock solid as always.

erikarvstedt
erikarvstedt approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@erikarvstedt erikarvstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been running nsncd for 2 months on 5 systems without issues.
The occasional Firefox DNS errors after waking up from standby have disappeared.

rnhmjoj
rnhmjoj approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here: I've been using it without issues since the 22.11 release.
Switching to nsncd shouldn't be causing more trouble that DNS caching already is.

picnoir
picnoir approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@picnoir picnoir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also been using it on my systems for the last few months without any major issue.

@mweinelt mweinelt merged commit f7455fa into NixOS:master Feb 2, 2023
@Tungsten842 Tungsten842 mentioned this pull request Feb 2, 2023
Closed
@flokli flokli deleted the nsncd-as-default branch February 2, 2023 13:35
@Ericson2314
Copy link
Member

Congrats!

Mic92 added a commit to nix-community/srvos that referenced this pull request Feb 2, 2023
@Mic92
common: drop Nsncd option
fdd3335 
this is now upstream: NixOS/nixpkgs#214153
@Mic92 Mic92 mentioned this pull request Feb 2, 2023
Merged
zimbatm pushed a commit to nix-community/srvos that referenced this pull request Feb 4, 2023
@Mic92 @zimbatm
common: drop Nsncd option
ada2da9 
this is now upstream: NixOS/nixpkgs#214153
@ElvishJerricco ElvishJerricco mentioned this pull request Feb 18, 2023
Closed
12 tasks
@Majiir Majiir mentioned this pull request Oct 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikarvstedt erikarvstedt erikarvstedt approved these changes

@NickCao NickCao NickCao approved these changes

@rnhmjoj rnhmjoj rnhmjoj approved these changes

@picnoir picnoir picnoir approved these changes

@lukegb lukegb lukegb approved these changes

@mweinelt mweinelt mweinelt approved these changes

@zimbatm zimbatm Awaiting requested review from zimbatm

@Mic92 Mic92 Awaiting requested review from Mic92

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@ctheune ctheune Awaiting requested review from ctheune

@arianvp arianvp Awaiting requested review from arianvp

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@dasJ dasJ Awaiting requested review from dasJ

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@flokli @Ericson2314 @mweinelt @lukegb @picnoir @rnhmjoj @NickCao @erikarvstedt