Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.pyml: fix test on darwin #213706

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

Et7f3
Copy link
Contributor

@Et7f3 Et7f3 commented Jan 31, 2023

Description of changes

Caught while reviewing #162385

Things done

While building I saw:

building
       clang pyml_arch.ml.sharp
clang-11: warning: argument unused during compilation: '-fno-strict-overflow' [-Wunused-command-line-argument]
       clang numpy_stubs.o
clang-11: warning: argument unused during compilation: '-fno-strict-overflow' [-Wunused-command-line-argument]
       clang pyml_stubs.o
clang-11: warning: argument unused during compilation: '-fno-strict-overflow' [-Wunused-command-line-argument]

it seem that clang doesn't handle this argument where should I change it ? in cc-wrapper ?

I also added IPython because some test where skipped.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 31, 2023
@wegank wegank merged commit b1bb4e5 into NixOS:master Jan 31, 2023
@Et7f3 Et7f3 deleted the fix_ocamlPackages.pyml_darwin branch January 31, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants