Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubo: 0.17.0 -> 0.18.1 #212503

Merged
merged 2 commits into from
Mar 3, 2023
Merged

kubo: 0.17.0 -> 0.18.1 #212503

merged 2 commits into from
Mar 3, 2023

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Jan 24, 2023 •
edited
Loading

Description of changes

https://github.com/ipfs/kubo/releases/tag/v0.18.0
https://github.com/ipfs/kubo/releases/tag/v0.18.1

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Luflosi Luflosi marked this pull request as draft January 24, 2023 23:09
@Luflosi
Copy link
Contributor Author

Luflosi commented Jan 24, 2023

#209304 needs to be merged before this PR.

@ofborg ofborg bot requested a review from fpletz January 24, 2023 23:21
@bbjubjub2494
Copy link
Member

I noticed that meta.description is a bit wrong now that Kubo has been renamed. Kubo is "An IPFS implementation in Go" (Github tagline) not "A global, versioned, peer-to-peer filesystem".

@Luflosi Luflosi changed the title kubo: 0.17.0 -> 0.18.0 kubo: 0.17.0 -> 0.18.1 Feb 1, 2023
@Luflosi
Copy link
Contributor Author

Luflosi commented Feb 1, 2023

I updated the description.

@Luflosi
Copy link
Contributor Author

Luflosi commented Feb 28, 2023

Rebased.

Since #209304 was merged, this PR is now ready.

@Luflosi Luflosi marked this pull request as ready for review February 28, 2023 00:25
fabianhjr
fabianhjr approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@fabianhjr fabianhjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build, ran, works, NixOS x86_64

@fabianhjr fabianhjr added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 3, 2023
@fabianhjr fabianhjr requested a review from bbjubjub2494 March 3, 2023 14:59
@K900
Copy link
Contributor

K900 commented Mar 3, 2023

Uhh why me? ^^"

@fabianhjr
Copy link
Member

Someone to merge if the review so far is enough :'v

(Need a nixpkgs/committer)

@K900 K900 merged commit b1da477 into NixOS:master Mar 3, 2023
@K900
Copy link
Contributor

K900 commented Mar 3, 2023

/shrug

@fabianhjr
Copy link
Member

TY @K900 :3

@Luflosi Luflosi deleted the update/kubo branch March 3, 2023 16:00
@Luflosi
Copy link
Contributor Author

Luflosi commented Mar 3, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianhjr fabianhjr fabianhjr approved these changes

@fpletz fpletz Awaiting requested review from fpletz

@K900 K900 Awaiting requested review from K900

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@bbjubjub2494 bbjubjub2494 Awaiting requested review from bbjubjub2494

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Luflosi @bbjubjub2494 @K900 @fabianhjr