nheko: build with gcc 11 #211776

rnhmjoj · 2023-01-20T14:30:35Z

Description of changes

This should fix the aarch64 build where stdenv still defaults to gcc 9.

Things done

rnhmjoj · 2023-01-20T14:32:04Z

uninsane · 2023-01-20T22:37:08Z

aarch64 build is still broken in the same way: https://github.com/NixOS/nixpkgs/pull/211776/checks?check_run_id=10782064902 (i've replicated this failure locally, as well)

looks like nheko's still building with gcc 9 for some reason: https://logs.nix.ci/?key=nixos/nixpkgs.211776&attempt_id=316673cb-1cf3-4250-88c5-38f1924ae8a7

-- The CXX compiler identification is GNU 9.5.0
-- The C compiler identification is GNU 9.5.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /nix/store/1aaqc3ln9rb8nbbjrr8izwr3flb9aiql-gcc-wrapper-9.5.0/bin/g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /nix/store/1aaqc3ln9rb8nbbjrr8izwr3flb9aiql-gcc-wrapper-9.5.0/bin/gcc - skipped

x86-64 shows an error too, about the new compiler flag being unrecognized. i assume that's because it's also using the old gcc, but haven't confirmed.

nheko doesn't actually use its stdenv argument for anything interesting. i'll bet overriding the cmake argument would be the path to get a newer gcc in there.

uninsane · 2023-01-20T22:56:11Z

i'm able to actually override the gcc version with this:

   nheko = libsForQt5.callPackage ../applications/networking/instant-messengers/nheko {
     stdenv = gcc11Stdenv;
+    mkDerivation = libsForQt5.mkDerivationWith gcc11Stdenv.mkDerivation;
   };

the stdenv = override is probably not strictly necessary then. no idea what are the implications of doing this though.

edit: but now there's a linker error:

[ 71%] Linking CXX executable nheko
/nix/store/i8rnhjwfzjwvdkbhzyldi81jvraiz232-binutils-2.39/bin/ld: nheko: hidden symbol `__aarch64_cas4_acq_rel' in /nix/store/pq4x2qmdfnr4y982zmxwjq61m40cnz5r-gcc-11.3.0/lib/gcc/aarch64-unknown-linux-gnu/11.3.0/libgcc.a(cas_4_4.o) is referenced by DSO
/nix/store/i8rnhjwfzjwvdkbhzyldi81jvraiz232-binutils-2.39/bin/ld: final link failed: bad value
collect2: error: ld returned 1 exit status

This should fix the aarch64 build where stdenv still defaults to gcc 9.

rnhmjoj · 2023-01-21T00:57:29Z

Thanks, I suspected Qt had something to do with it: another reason to not use mkDerivation.
The link issue seems to be of the same underlying issue: setting the same flag doesn't work, but I suspect because it's being ignored somehow.

NickCao · 2023-01-21T01:34:08Z

The qt5.mkDerivation function has been deprecated in #108888

diff --git a/pkgs/applications/networking/instant-messengers/nheko/default.nix b/pkgs/applications/networking/instant-messengers/nheko/default.nix
index 680833ca2e6..09819510136 100644
--- a/pkgs/applications/networking/instant-messengers/nheko/default.nix
+++ b/pkgs/applications/networking/instant-messengers/nheko/default.nix
@@ -1,6 +1,5 @@
 { lib
 , stdenv
-, mkDerivation
 , fetchFromGitHub
 , cmake
 , asciidoc
@@ -24,6 +23,7 @@
 , qtmultimedia
 , qtquickcontrols2
 , qttools
+, wrapQtAppsHook
 , re2
 , spdlog
 , voipSupport ? true
@@ -31,7 +31,7 @@
 , libnice
 }:

-mkDerivation rec {
+stdenv.mkDerivation rec {
   pname = "nheko";
   version = "0.11.1";

@@ -47,6 +47,7 @@ mkDerivation rec {
     cmake
     lmdbxx
     pkg-config
+    wrapQtAppsHook
   ];

   buildInputs = [

Edit: the linking error persists, guess that we just cannot bypass that problem introduced in our bootstrap process.

ghost · 2023-01-21T11:11:11Z

No dice:

       > [ 71%] Linking CXX executable nheko
       > /nix/store/i8rnhjwfzjwvdkbhzyldi81jvraiz232-binutils-2.39/bin/ld: nheko: hidden symbol `__aarch64_cas4_acq_rel' in /nix/store/pq4x2qmdfnr4y982zmxwjq61m40cnz5r-gcc-11.3.0/lib/gcc/aarch64-unknown-linux-gnu/11.3.0/libgcc.a(cas_4_4.o) is referenced by DSO
       > /nix/store/i8rnhjwfzjwvdkbhzyldi81jvraiz232-binutils-2.39/bin/ld: final link failed: bad value
       > collect2: error: ld returned 1 exit status
       > make[2]: *** [CMakeFiles/nheko.dir/build.make:4119: nheko] Error 1
       > make[1]: *** [CMakeFiles/Makefile2:150: CMakeFiles/nheko.dir/all] Error 2
       > make: *** [Makefile:136: all] Error 2
       For full logs, run 'nix log /nix/store/19hniicm81cv9pjh2i86pbswm42k001q-nheko-0.11.1.drv'.

I don't think this approach is going to work unless you add -mno-outline-atomics to all of nheko's dependencies too.

Or we could just fix the bootstrap. 🤷

rnhmjoj · 2023-01-21T11:11:36Z

The link issue seems to be of the same underlying issue

I confirmed with NIX_DEBUG that the flag is being set, so it must be something else.

ghost · 2023-01-21T11:12:16Z

I confirmed with NIX_DEBUG that the flag is being set, so it must be something else.

You need to set the flag in all of nheko's dependencies too. If you're trying to fix it that way.

rnhmjoj · 2023-01-21T13:10:03Z

You need to set the flag in all of nheko's dependencies too. If you're trying to fix it that way.

Well, then I guess it stays broken because this is unfeasible.

uninsane · 2023-01-21T20:31:13Z

fair enough. it sounds like the bootstrap stuff should make this easier if we just wait for that. i want to investigate a (temporary) source patch, but no idea when i’ll have the time for that. what about the nixos-22.11 branch though? what was the motivation for backporting the nheko update? unless it was a security fix or something, i’d push to revert that branch to a version that builds on arm (any 0.10.x, i think).

…

On Jan 21, 2023, at 13:10, Michele Guerini Rocco ***@***.***> wrote: Well, then I guess it stays broken because this is unfeasible. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.

rnhmjoj · 2023-01-21T21:46:17Z

unless it was a security fix or something, i’d push to revert that branch to a version that ...

Nothing in particular, I normally backport updates for leaf packages like nheko. Sorry I didn't pay attention to the aarch64 failure, I guess I assume it was already broken. I'm ok with reverting.

NickCao · 2023-01-22T00:15:37Z

Revert done in #212014 and #212013

rnhmjoj · 2023-01-22T02:06:13Z

Uhm, I would have reverted only for 22.11. What are we supposed to do in case an update break a tier-2 platform?
Should a single platform hold the update for the rest?

wegank · 2023-01-22T07:13:07Z

No dice:

       > [ 71%] Linking CXX executable nheko
       > /nix/store/i8rnhjwfzjwvdkbhzyldi81jvraiz232-binutils-2.39/bin/ld: nheko: hidden symbol `__aarch64_cas4_acq_rel' in /nix/store/pq4x2qmdfnr4y982zmxwjq61m40cnz5r-gcc-11.3.0/lib/gcc/aarch64-unknown-linux-gnu/11.3.0/libgcc.a(cas_4_4.o) is referenced by DSO
       > /nix/store/i8rnhjwfzjwvdkbhzyldi81jvraiz232-binutils-2.39/bin/ld: final link failed: bad value
       > collect2: error: ld returned 1 exit status
       > make[2]: *** [CMakeFiles/nheko.dir/build.make:4119: nheko] Error 1
       > make[1]: *** [CMakeFiles/Makefile2:150: CMakeFiles/nheko.dir/all] Error 2
       > make: *** [Makefile:136: all] Error 2
       For full logs, run 'nix log /nix/store/19hniicm81cv9pjh2i86pbswm42k001q-nheko-0.11.1.drv'.

I don't think this approach is going to work unless you add -mno-outline-atomics to all of nheko's dependencies too.

Or we could just fix the bootstrap. 🤷

I think the canonical fix is to stick to -lgcc (and it works, see #212051).

rnhmjoj mentioned this pull request Jan 20, 2023

mtxclient, nheko fail to build on aarch64-linux #211758

Closed

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes labels Jan 20, 2023

rnhmjoj added 2 commits January 21, 2023 01:54

nheko: build with gcc 11

20a46d8

This should fix the aarch64 build where stdenv still defaults to gcc 9.

coeurl: fix aarch64 build

8cb19ef

ghost mentioned this pull request Jan 21, 2023

stdenv: Nix-driven bootstrap of gcc #209870

Merged

4 tasks

rnhmjoj force-pushed the pr-nheko branch from adc03d6 to 8cb19ef Compare January 21, 2023 09:32

ofborg bot requested review from fpletz and Ekleog January 21, 2023 09:45

rnhmjoj closed this Jan 22, 2023

rnhmjoj deleted the pr-nheko branch July 10, 2023 13:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nheko: build with gcc 11 #211776

nheko: build with gcc 11 #211776

rnhmjoj commented Jan 20, 2023

rnhmjoj commented Jan 20, 2023

uninsane commented Jan 20, 2023

uninsane commented Jan 20, 2023 •

edited

Loading

rnhmjoj commented Jan 21, 2023

NickCao commented Jan 21, 2023 •

edited

Loading

ghost commented Jan 21, 2023

rnhmjoj commented Jan 21, 2023

ghost commented Jan 21, 2023

rnhmjoj commented Jan 21, 2023

uninsane commented Jan 21, 2023 via email

rnhmjoj commented Jan 21, 2023

NickCao commented Jan 22, 2023

rnhmjoj commented Jan 22, 2023

wegank commented Jan 22, 2023

nheko: build with gcc 11 #211776

nheko: build with gcc 11 #211776

Conversation

rnhmjoj commented Jan 20, 2023

Description of changes

Things done

rnhmjoj commented Jan 20, 2023

uninsane commented Jan 20, 2023

uninsane commented Jan 20, 2023 • edited Loading

rnhmjoj commented Jan 21, 2023

NickCao commented Jan 21, 2023 • edited Loading

ghost commented Jan 21, 2023

rnhmjoj commented Jan 21, 2023

ghost commented Jan 21, 2023

rnhmjoj commented Jan 21, 2023

uninsane commented Jan 21, 2023 via email

rnhmjoj commented Jan 21, 2023

NickCao commented Jan 22, 2023

rnhmjoj commented Jan 22, 2023

wegank commented Jan 22, 2023

uninsane commented Jan 20, 2023 •

edited

Loading

NickCao commented Jan 21, 2023 •

edited

Loading