nixpkgs manual: Remove obsolete warning #21117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lheckemann, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vcunat, @edolstra and @dezgeg to be potential reviewers. |
|
NixOS/nix#815 has been merged, but the default nix version does not contain it yet. See #19761 (comment) |
|
Ah right, perhaps the warning should just be reworded then... |
PR NixOS#815 has already been merged
lheckemann
force-pushed
the
master
branch
2 times, most recently
from
0192614 to
88c5899
Compare
|
Ping |
|
@domenkozar: any indication the situation has changed? I sadly still see 1.11.6 as the default, without that PR contained or picked. |
|
Ah, I'm sorry – you probably meant that the rewording should be done. |
|
Since 1.11.8 is now the default version and contains the commit in question, I'm guessing this can be merged? |
vcunat
pushed a commit
that referenced
this pull request
Apr 23, 2017
|
Right, even though the situation isn't ideal, as discussed in #24717. |
drawnwren
pushed a commit
to drawnwren/nixpkgs
that referenced
this pull request
Apr 23, 2017
PR NixOS#815 has already been cherry-picked into the default nix version 1.11.8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #815 has already been merged.