Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdenv: aarch64-linux: gcc9 -> gcc11 #211007

Closed
wants to merge 1 commit into from
Closed

Conversation

wegank
Copy link
Member

@wegank wegank commented Jan 16, 2023

Description of changes

Here we go!

$ nix-build -A stdenv
/nix/store/x0vcrqypn803in7i7hdd3ll8r9fqhbks-stdenv-linux
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@wegank wegank requested a review from trofi January 16, 2023 01:11
@wegank wegank mentioned this pull request Jan 16, 2023
13 tasks
@tpwrules
Copy link
Contributor

tpwrules commented Jan 16, 2023

I was unaware that a PR got merged to make this possible? Testing now...

@wegank
Copy link
Member Author

wegank commented Jan 16, 2023

@tpwrules The fix came from #209055.

@wegank
Copy link
Member Author

wegank commented Jan 16, 2023

@ofborg build stdenv

@wegank
Copy link
Member Author

wegank commented Jan 16, 2023

And it goes well on Hydra too.

@wegank wegank mentioned this pull request Jan 16, 2023
13 tasks
@tpwrules
Copy link
Contributor

icu fails to build still, with a different error granted, but it's about the same symbol:

g++ -O2 -W -Wall -pedantic -Wpointer-arith -Wwrite-strings -Wno-long-long -std=c++11     -o ../../bin/makeconv gencnvex.o genmbcs.o makeconv.o ucnvstat.o -L../../lib -licutu -L../../lib -licui18n -L../../lib -licuuc -L../../stubdata -licudata -lpthread -lm  
/nix/store/dgbbnlsmwx9vbk43adypvc4dqylfag9n-binutils-2.39/bin/ld: ../../bin/makeconv: hidden symbol `__aarch64_ldadd4_acq_rel' in /nix/store/ihjgrb8nbdi885sm042bfpvh269vd6m3-gcc-11.3.0/lib/gcc/aarch64-unknown-linux-gnu/11.3.0/libgcc.a(ldadd_4_4.o) is referenced by DSO
/nix/store/dgbbnlsmwx9vbk43adypvc4dqylfag9n-binutils-2.39/bin/ld: final link failed: bad value
collect2: error: ld returned 1 exit status

dejagnu is fine though

@tpwrules
Copy link
Contributor

Confirmed that icu and dejagnu both build at the commit before this one so upgrading to 11 definitely still breaks things.

@wegank wegank marked this pull request as draft January 16, 2023 02:45
@wegank wegank closed this Jan 16, 2023
@wegank wegank deleted the gcc11-bump branch January 16, 2023 02:47
@ofborg ofborg bot requested review from adevress and SuperSandro2000 January 16, 2023 03:17
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jan 16, 2023
@trofi
Copy link
Contributor

trofi commented Jan 16, 2023

The fix came from #209055.

Unfortunately it's a no-op change as long as we we use bootstrap -> binutils -> glibc -> binutils bootstrap sequence (here glibc still embeds libgcc_s.so.1 from bootstrap).

It will have an effect only after #209063 gets merged. There bootstrap -> gcc -> binutils -> glibc -> binutils will have a chance to embed newer libgcc_s.so.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants