Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yubioath-desktop: fix dependencies on 22.11 #209098

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Conversation

rkjnsn
Copy link
Contributor

@rkjnsn rkjnsn commented Jan 4, 2023

yubioath-desktop has been removed on unstable in favor of yubioath-flutter, but 22.11 currently only has the former, and it's broken due to #202295. This change fixes it by depending on the previous, compatible version of the yubikey-manager library.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

yubioath-desktop has been removed on unstable in favor of yubioath-flutter, but 22.11 currently only has the former, and it's broken due to NixOS#202295. This change fixes it by depending on the previous, compatible version of the yubikey-manager library.
@rkjnsn
Copy link
Contributor Author

rkjnsn commented Jan 4, 2023

@Mic92 @rissson

@ofborg ofborg bot requested review from rissson and Mic92 January 4, 2023 23:00
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jan 4, 2023
@Mic92 Mic92 merged commit c013ff8 into NixOS:release-22.11 Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants