Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: bring back 1.65 for aarch64-linux #209078

Closed
wants to merge 2 commits into from
Closed

Conversation

figsoda
Copy link
Member

@figsoda figsoda commented Jan 4, 2023

Description of changes

rustc failds to build on staging for aarch64-linux: https://hydra.nixos.org/build/203858528/nixlog/7, I wasn't able to fix the build, so I brought back 1.65 as a temporary solution

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@wegank
Copy link
Member

wegank commented Jan 4, 2023

#201254

@wegank
Copy link
Member

wegank commented Jan 4, 2023

A temporary solution would be, as in #201485, to switch to gcc11Stdenv and pass -lgcc to NIX_LDFLAGS.

@figsoda figsoda marked this pull request as draft January 4, 2023 20:48
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 4, 2023
@winterqt
Copy link
Member

winterqt commented Jan 4, 2023

A temporary solution would be, as in #201485, to switch to gcc11Stdenv and pass -lgcc to NIX_LDFLAGS.

AFAIU, this should work; testing now. Works! Once I finish compiling/testing it, I'll PR.

@winterqt
Copy link
Member

winterqt commented Jan 4, 2023

Closing in favor of #209113.

@winterqt winterqt closed this Jan 4, 2023
@figsoda figsoda deleted the rustc branch January 4, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: rust 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants