-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/systemd: document what scriptArgs
is for
#207268
Conversation
Would be nice to have manpage links working in
|
790b143
to
feb9ba5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. as for linking in options.html
, we could move the manpage reference table to a special doc attribute that generates an MD footer with link targets? that way the renderers could remain agnostic and html output can get automatic linking with no extra effort.
["tmpfiles.d(5)"] = "https://www.freedesktop.org/software/systemd/man/tmpfiles.d.html", | ||
["systemd.time(7)"] = "https://www.freedesktop.org/software/systemd/man/systemd.time.html", | ||
["systemd-fstab-generator(8)"] = "https://www.freedesktop.org/software/systemd/man/systemd-fstab-generator.html", | ||
["systemd-networkd-wait-online.service(8)"] = "https://www.freedesktop.org/software/systemd/man/systemd-networkd-wait-online.service.html", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it doesn't seem to work? When I render the manual and load the options page, I don't see any replacements. Maybe this operates on the docbook, which is structured?
def manpage(self, page, section):
title = f"<refentrytitle>{escape(page)}</refentrytitle>"
vol = f"<manvolnum>{escape(section)}</manvolnum>"
return f"<citerefentry>{title}{vol}</citerefentry>"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, see #207268 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see. I thought you implemented that. I should've clicked the link in that comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May need a fix
["tmpfiles.d(5)"] = "https://www.freedesktop.org/software/systemd/man/tmpfiles.d.html", | ||
["systemd.time(7)"] = "https://www.freedesktop.org/software/systemd/man/systemd.time.html", | ||
["systemd-fstab-generator(8)"] = "https://www.freedesktop.org/software/systemd/man/systemd-fstab-generator.html", | ||
["systemd-networkd-wait-online.service(8)"] = "https://www.freedesktop.org/software/systemd/man/systemd-networkd-wait-online.service.html", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it doesn't seem to work? When I render the manual and load the options page, I don't see any replacements. Maybe this operates on the docbook, which is structured?
def manpage(self, page, section):
title = f"<refentrytitle>{escape(page)}</refentrytitle>"
vol = f"<manvolnum>{escape(section)}</manvolnum>"
return f"<citerefentry>{title}{vol}</citerefentry>"
@pennae that would require changing the manpage syntax to something like |
not necessarily. once we actually render from markdown to html/manpages/… directly each renderer can process the manpage tag as appropriate, the default being "the traditional text representation" and the html renderer overriding that to wrap it in a link.
was thinking about only option docs for that suggestion. if the manpage maps are json the option docs build process could load them and set them as a default map for eg |
Well, if we want this to work with a footer (I'm assuming you're talking about https://pandoc.org/MANUAL.html#reference-links), the manpage references must have that shape, so we'd need a step that converts |
Done in #208762 |
Related to #154123, I guess