Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prusa-slicer: fix build #206221

Closed
wants to merge 1 commit into from
Closed

Conversation

gador
Copy link
Member

@gador gador commented Dec 15, 2022

Description of changes

fixes cgal-5.5.1/include/CGAL/GMP/Gmpfr_type.h:237:33: error: invalid conversion from 'mpfr_srcptr' {aka 'const __mpfr_struct*'} to 'mpfr_ptr' {aka '__mpfr_struct*'} [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-fpermissive-fpermissive8;;]

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

fixes "cgal-5.5.1/include/CGAL/GMP/Gmpfr_type.h:237:33: error: invalid
conversion from 'mpfr_srcptr' {aka 'const __mpfr_struct*'} to 'mpfr_ptr'
{aka '__mpfr_struct*'}
[8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-fpermissive-fpermissive8;;]"

Signed-off-by: Florian Brandes <[email protected]>
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 15, 2022
@0x4A6F
Copy link
Member

0x4A6F commented Dec 15, 2022

There is a regression in mpfr and it should be fixed by cfe4a8d and 35cff8f which are already in staging-next..

@gador
Copy link
Member Author

gador commented Dec 16, 2022

works with cherry-pickling those commits. Thanks!

@gador gador closed this Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants