Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python310Packages.dill: 0.3.5.1 -> 0.3.6 #198883

Merged
merged 1 commit into from
Nov 12, 2022
Merged

python310Packages.dill: 0.3.5.1 -> 0.3.6 #198883

merged 1 commit into from
Nov 12, 2022

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Nov 1, 2022

  1. Update version so that it is compatible with Python 3.11.
  2. Run tests the same way that dill does.
  3. Add myself to the maintainer list.

I also tried to fix the tests using pytest and pytestCheckHook, but I could not do it. I found uqfoundation/dill#460, which has more information about this difficulty. In the meantime, I feel it is better to run all the tests in a custom way than stick to pytest and skip many of them.

I found that this is needed also by #198533.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@tjni tjni requested review from FRidh and jonringer as code owners November 1, 2022 06:28
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 labels Nov 1, 2022
1. Update version so that it is compatible with Python 3.11.
2. Run tests the same way that dill does.
3. Add myself to the maintainer list.
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1366

@SuperSandro2000
Copy link
Member

@AndersonTorres what you suggested is completely forbidden in python packages.

@AndersonTorres
Copy link
Member

@AndersonTorres what you suggested is completely forbidden in python packages.

Why? I thougth it is common...

@SuperSandro2000
Copy link
Member

Because it breaks splicing. It is really common to use this outside of pythonPackages where it saves code but there we also do not need splicing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants