-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python310Packages.dill: 0.3.5.1 -> 0.3.6 #198883
Conversation
1. Update version so that it is compatible with Python 3.11. 2. Run tests the same way that dill does. 3. Add myself to the maintainer list.
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/1366 |
@AndersonTorres what you suggested is completely forbidden in python packages. |
Why? I thougth it is common... |
Because it breaks splicing. It is really common to use this outside of pythonPackages where it saves code but there we also do not need splicing. |
I also tried to fix the tests using pytest and pytestCheckHook, but I could not do it. I found uqfoundation/dill#460, which has more information about this difficulty. In the meantime, I feel it is better to run all the tests in a custom way than stick to pytest and skip many of them.
I found that this is needed also by #198533.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes