Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/kernel: replace boot.isContainer with boot.kernel.enable #197917

Merged
merged 1 commit into from
Nov 12, 2022

Conversation

SuperSandro2000
Copy link
Member

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@SuperSandro2000 SuperSandro2000 requested a review from dasJ as a code owner October 26, 2022 14:52
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 26, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 26, 2022
@SuperSandro2000 SuperSandro2000 force-pushed the kernel-enable branch 3 times, most recently from ccbba6f to 352a116 Compare October 26, 2022 17:18
Copy link
Member

@ncfavier ncfavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be more places where !config.boot.isContainer should be replaced with config.boot.kernel.enable. Can't really say without knowing what use case you have in mind.

nixos/modules/system/boot/kernel.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member Author

There might be more places where !config.boot.isContainer should be replaced with config.boot.kernel.enable.

Do you have some in mind? I think I got all of them that are relevant for my usecase.

Can't really say without knowing what use case you have in mind.

NixOS-WSL, see https://github.com/nix-community/NixOS-WSL/blob/a4bbcf329a98a7faf79d10370278f87e836e1d7c/modules/wsl-distro.nix#L102-L105

@SuperSandro2000 SuperSandro2000 merged commit 9477fa1 into NixOS:master Nov 12, 2022
@SuperSandro2000 SuperSandro2000 deleted the kernel-enable branch November 12, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants