Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

erlang: 25.1 -> 25.1.2 #196785

Merged
merged 1 commit into from
Nov 8, 2022
Merged

erlang: 25.1 -> 25.1.2 #196785

merged 1 commit into from
Nov 8, 2022

Conversation

shanesveller
Copy link
Contributor

@shanesveller shanesveller commented Oct 19, 2022 •
edited
Loading

Description of changes

https://www.erlang.org/patches/otp-25.1.1

Per erlang/rebar3#2747 , fixes an issue with rebar3's test suite on OTP 25. Prior to this PR I could not build beam.packages.erlangR25.rebar3, but it passes successfully now. I still cannot build beam.packages.erlangR25.erlang-ls for unrelated reasons, but this seems to be a step in the right direction for that too?

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@shanesveller shanesveller marked this pull request as ready for review October 19, 2022 17:03
@shanesveller shanesveller changed the title erlang: 25.1 -> 25.1.1 erlang: 25.1 -> 25.1.2 Nov 6, 2022
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1359

@AndersonTorres
Copy link
Member

I still cannot build beam.packages.erlangR25.erlang-ls for unrelated reasons, but this seems to be a step in the right direction for that too?

Solved?

@shanesveller
Copy link
Contributor Author

@AndersonTorres It still failed for me as of 9014fb7 when running nix -vL build .#beam.packages.erlangR25.erlang-ls, in the project's test suite.

https://gist.github.com/f055f61334f15e7dbdc8aaaa841d9e24

@SuperSandro2000 SuperSandro2000 merged commit f0f084d into NixOS:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: erlang 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shanesveller @nixos-discourse @AndersonTorres @SuperSandro2000