haskell-language-server: Add shell-wrapper which detects ABI incompatibilities #192540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maralorn
requested review from
cdepillabout and
sternenseemann
as code owners
|
Wow, the editorconfig wants me to update a script which currently differs in three lines from upstream to swap spaces for tabs so it differs in ~100 lines from upstream. Is there a way I can work around this? |
zowoq
reviewed
Sep 23, 2022
|
I have created a PR on upstream modifying the wrapper script and adding it to the hackage release. If that get’s accepted we can get away without maintaining our own version of the script. |
maralorn
force-pushed
the
hls-abi-wrapper
branch
2 times, most recently
from
8088d85 to
41a84e2
Compare
maralorn
force-pushed
the
hls-abi-wrapper
branch
from
6fad443 to
d18b30d
Compare
|
Drafting this until we have a decision on upstream, it’s not to urgent. |
…ibilities This checks that ghc and its boot libraries have the same ABI at runtime as at compile time. Co-authored-by: sternenseemann <[email protected]>
maralorn
force-pushed
the
hls-abi-wrapper
branch
from
d18b30d to
52962fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This introduces a ghc + boot libraries ABI Hash comparison between compile and runtime to increase the probability that hls works with this setup.
As explained in #175565 I needed a few modifications to the wrapper script, so I don‘t see an alternative to copying it into nixpkgs. (It’s currently not contained in the sdist on hackage anyways.)
The change is that instead of checking that the list of packages is exactly the same we only check that the packages present at compile time are present with the same abi hash at runtime.
Closes: #175565
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes