Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rPackages: reenable stackprotector on aarch64-darwin #189760

Merged
merged 1 commit into from
Sep 17, 2022
Merged

rPackages: reenable stackprotector on aarch64-darwin #189760

merged 1 commit into from
Sep 17, 2022

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Sep 4, 2022 •
edited
Loading

The original error that required disabling the stack protector on aarch64-darwin has been fixed in GCC (in #186477). This reverts the change in #165765.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@tjni
rPackages: reenable stackprotector on aarch64-darwin
e0a5a1c 
The original error that required disabling the stack protector on
aarch64-darwin has been fixed in GCC.
@tjni tjni requested a review from jbedo as a code owner September 4, 2022 18:49
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Sep 4, 2022
@tjni
Copy link
Contributor Author

tjni commented Sep 4, 2022

Result of nixpkgs-review pr 189760 run on aarch64-darwin 1

3 packages built:
  • python310Packages.rpy2
  • python39Packages.rpy2
  • rWrapper

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1188

@SuperSandro2000
Copy link
Member

@ofborg build python310Packages.cnvkit python310Packages.rpy2

@SuperSandro2000 SuperSandro2000 merged commit 5cd03ed into NixOS:master Sep 17, 2022
@tjni tjni deleted the r-modules-stackprotector branch September 17, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbedo jbedo Awaiting requested review from jbedo

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tjni @nixos-discourse @SuperSandro2000