Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-cpufreq: 1.7.1 -> 1.9.6 #187047

Closed
wants to merge 2 commits into from
Closed

Conversation

reedriley
Copy link
Contributor

@reedriley reedriley commented Aug 17, 2022

Description of changes

Release summaries: https://github.com/AdnanHodzic/auto-cpufreq/releases

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Technical27 August 17, 2022 00:44
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Aug 17, 2022
pkgs/tools/system/auto-cpufreq/default.nix Show resolved Hide resolved
@@ -25,15 +30,18 @@ python3Packages.buildPythonPackage rec {

# patch to prevent script copying and to disable install
./prevent-install-and-copy.patch

# patch to remove venvs from the service file
./remove-service-venv.patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any upstream issues or PR related to these patches?

Copy link
Contributor Author

@reedriley reedriley Aug 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are issues complaining about venv stuff, but they're mostly resolved by users switching to the Snap package.

Basically this is just an artifact of how auto-cpufreq is typically installed that prevents us from trivially upgrading from version 1.7.1. As far as I can tell - it's not necessary except to reduce the dependency on the system python version.

@reedriley reedriley changed the title auto-cpufreq: 1.7.1 -> 1.9.5 auto-cpufreq: 1.7.1 -> 1.9.6 Oct 1, 2022
@SebTM SebTM mentioned this pull request Apr 16, 2023
12 tasks
@wegank
Copy link
Member

wegank commented Sep 6, 2023

Superseded by #253595.

@wegank wegank closed this Sep 6, 2023
@reedriley reedriley deleted the auto-cpufreq branch April 2, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants