Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qcoro: 0.4.0 -> 0.6.0 #185191

Closed
wants to merge 1 commit into from
Closed

Conversation

puffnfresh
Copy link
Member

And fix compilation on aarch64 by supplying GCC 11.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Aug 5, 2022
@ofborg ofborg bot requested a review from syvb August 5, 2022 07:29
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Aug 5, 2022
@syvb
Copy link
Member

syvb commented Aug 5, 2022

Result of nixpkgs-review pr 185191 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • libsForQt512.neochat
  • libsForQt512.spacebar
  • libsForQt514.neochat
  • libsForQt514.spacebar
1 package failed to build:
  • libsForQt512.qcoro
4 packages built:
  • libsForQt5.neochat (libsForQt515.neochat ,plasma5Packages.neochat)
  • libsForQt5.qcoro (libsForQt515.qcoro ,plasma5Packages.qcoro)
  • libsForQt5.spacebar (libsForQt515.spacebar ,plasma5Packages.spacebar)
  • libsForQt514.qcoro

, libpthreadstubs
, qtbase
, qtwebsockets
}:

mkDerivation rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mkDerivation rec {
stdenv.mkDerivation rec {

And fix compilation on aarch64 by supplying GCC 11.
@samueldr
Copy link
Member

@puffnfresh it looks like the packages depending on qcoro also need to use GCC11. Else they, too, fail with:

g++: error: unrecognized command line option '-fcoroutines'

I also think using gcc11Stdenv is the proper way to go. Yes we're losing some niceties from the Qt5 mkderivation, but uh, that's how the cookie crumbles.

I want you to check the changes here, if you think they're alright (or if a few days pass) we can push this to this PR and merge. Tested to build and run on x86_64 and aarch64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants