Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

julia: build julia_17-bin on aarch64-darwin #181772

Closed
wants to merge 3 commits into from
Closed

Conversation

Smaug123
Copy link
Contributor

Description of changes

Expand julia_17-bin to aarch64-darwin.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package labels Jul 16, 2022
@ofborg ofborg bot requested review from 7c6f434c and a user July 16, 2022 22:41
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jul 16, 2022
@ghost
Copy link

ghost commented Jul 17, 2022 via email

@Smaug123
Copy link
Contributor Author

I'm about to go on a week of holiday and won't have time to get back to this until afterwards.

I'm still chasing down a few failing tests locally, so this PR is very much not ready to go in; and there's a chance that I'll never get it working, given the lack of upstream support. I was a bit wary of adding the x86-64 target because I haven't tested that. Thanks for the comments though, I'll make sure to address them before un-Drafting this PR.

The only reason I'm doing this is because I wanted to play around a bit with Julia without polluting my machine - I mostly expect to abandon Julia within a week or so! So I'm happy to be a maintainer if my maintenance is allowed to take the form "spend ten minutes trying to fix, and then mark as broken forever", but don't want to commit to anything more.

@ghost
Copy link

ghost commented Jul 19, 2022 via email

@Smaug123
Copy link
Contributor Author

Yeah, my Julia knowledge just isn't good enough here, and this is more effort than I'm willing to spend, I'm afraid :( if there were only one failing test, I might have a go, but there are several failing in ways that aren't obvious to me.

@ghost
Copy link

ghost commented Jul 27, 2022 via email

@wegank wegank mentioned this pull request Dec 11, 2022
13 tasks
@wegank
Copy link
Member

wegank commented Feb 2, 2023

Closed by #205584.

@wegank wegank closed this Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants