-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
julia: build julia_17-bin on aarch64-darwin #181772
Conversation
Looks pretty darn good! So all tests are passing despite upstream support only being Tier 2 for aarch64-darwin?
Minor comments on the patch itself:
1.) Since both aarch64-darwin and x86_64-darwin uses the same fetched tar ball, define it elsewhere so as not to write the same statement twice?
2.) autoPatchelfHook should probably be a negative check for Darwin than a positive check for Linux.
3.) Is the patch disabling HTTPS tests necessary for tests to pass for Linux? If not, condition its inclusion on Darwin.
4.) I think you forgot to add x86_64-darwin to platforms.
5.) We will need a maintainer for macOS, are you up for it?
|
I'm about to go on a week of holiday and won't have time to get back to this until afterwards. I'm still chasing down a few failing tests locally, so this PR is very much not ready to go in; and there's a chance that I'll never get it working, given the lack of upstream support. I was a bit wary of adding the x86-64 target because I haven't tested that. Thanks for the comments though, I'll make sure to address them before un-Drafting this PR. The only reason I'm doing this is because I wanted to play around a bit with Julia without polluting my machine - I mostly expect to abandon Julia within a week or so! So I'm happy to be a maintainer if my maintenance is allowed to take the form "spend ten minutes trying to fix, and then mark as broken forever", but don't want to commit to anything more. |
On Sun 17 Jul 2022, Patrick Stevens wrote:
I'm about to go on a week of holiday and won't have time to get back to this until afterwards.
No worries, enjoy your time off!
I'm still chasing down a few failing tests locally, so this PR is very much not ready to go in; and there's a chance that I'll never get it working, given the lack of upstream support. I was a bit wary of adding the x86-64 target because I haven't tested that. Thanks for the comments though, I'll make sure to address them before un-Drafting this PR.
All fine, do know that there is usually ample support to find over on the Julia Slack. Do not “suffer” alone with test failures, as I know it can be one heck of a challenge to find the root causes.
The only reason I'm doing this is because I wanted to play around a bit with Julia without polluting my machine - I mostly expect to abandon Julia within a week or so! So I'm happy to be a maintainer if my maintenance is allowed to take the form "spend ten minutes trying to fix, and then mark as broken forever", but don't want to commit to anything more.
If you end up with a working patch I am sure others will step up. No need to worry about this for now I suppose. I was under the impression that a merge was more imminent.
|
Yeah, my Julia knowledge just isn't good enough here, and this is more effort than I'm willing to spend, I'm afraid :( if there were only one failing test, I might have a go, but there are several failing in ways that aren't obvious to me. |
On Sun 24 Jul 2022, Patrick Stevens wrote:
Yeah, my Julia knowledge just isn't good enough here, and this is more effort than I'm willing to spend, I'm afraid :( if there were only one failing test, I might have a go, but there are several failing in ways that aren't obvious to me.
Sorry to hear that and the general difficulty mirrors my experience as well (I failed to get Julia to build reliably from source with Nixpkgs after about two months of on-and-off efforts, which is what led to julia-bin and friends).
I will keep this PR in mind and refer to it once the next Mac user comes along and wants to take a stab at getting things to work. My understanding is that the upstream is also unstable in part for aarch64-darwin, so it could also have been that your timing was unfortunate.
|
Closed by #205584. |
Description of changes
Expand
julia_17-bin
to aarch64-darwin.Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes