Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libaom: Fix static compilation #179266

Merged
merged 3 commits into from
Oct 15, 2022
Merged

libaom: Fix static compilation #179266

merged 3 commits into from
Oct 15, 2022

Conversation

dali99
Copy link
Member

@dali99 dali99 commented Jun 27, 2022 •
edited
Loading

Description of changes

Fixes static compilation for libaom, depends on #179102 #193609 (or we could just merge this one)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from nh2, codyopel, vcunat and paperdigits June 27, 2022 01:04
@ofborg ofborg bot requested review from primeos and kiloreux June 29, 2022 14:19
@alyssais alyssais added 6.topic: static 6.topic: musl Running or building packages with musl libc labels Jul 2, 2022
@dali99 dali99 force-pushed the libaom_static branch 2 times, most recently from 93114f0 to 981ca04 Compare July 8, 2022 20:56
@ofborg ofborg bot requested a review from ajs124 July 8, 2022 21:06
@ofborg ofborg bot requested a review from zhaofengli July 27, 2022 23:10
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ labels Aug 18, 2022
@dali99 dali99 requested a review from alyssais August 22, 2022 09:50
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 501+ 10.rebuild-darwin: 501-1000 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 30, 2022
r-burns
r-burns approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@r-burns r-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bobby285271 bobby285271 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 30, 2022
@r-burns r-burns merged commit 7578ab0 into NixOS:staging Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-burns r-burns r-burns approved these changes

@nh2 nh2 Awaiting requested review from nh2

@codyopel codyopel Awaiting requested review from codyopel

@vcunat vcunat Awaiting requested review from vcunat

@paperdigits paperdigits Awaiting requested review from paperdigits

@primeos primeos Awaiting requested review from primeos

@kiloreux kiloreux Awaiting requested review from kiloreux

@ajs124 ajs124 Awaiting requested review from ajs124

@zhaofengli zhaofengli Awaiting requested review from zhaofengli

@alyssais alyssais Awaiting requested review from alyssais

Assignees
No one assigned
Labels
6.topic: musl Running or building packages with musl libc 6.topic: static 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dali99 @r-burns @alyssais @bobby285271