Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python310Packages.cocotb: unbreak on Darwin #178918

Merged
merged 1 commit into from
Jun 26, 2022
Merged

python310Packages.cocotb: unbreak on Darwin #178918

merged 1 commit into from
Jun 26, 2022

Conversation

jiegec
Copy link
Contributor

@jiegec jiegec commented Jun 25, 2022 •
edited
Loading

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@jiegec jiegec requested review from FRidh and jonringer as code owners June 25, 2022 02:27
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jun 25, 2022
@jiegec
Copy link
Contributor Author

jiegec commented Jun 25, 2022

Result of nixpkgs-review pr 178918 run on aarch64-darwin 1

2 packages built:
  • python310Packages.cocotb
  • python39Packages.cocotb

@jiegec
Copy link
Contributor Author

jiegec commented Jun 25, 2022

Result of nixpkgs-review pr 178918 run on x86_64-darwin 1

2 packages built:
  • python310Packages.cocotb
  • python39Packages.cocotb

@ofborg ofborg bot requested a review from matthuszagh June 25, 2022 02:35
@jiegec
python310Packages.cocotb: unbreak on Darwin
ccde57b 
- Disable lto, see issue NixOS#19098

- Replace `-bundle` in LDCXXSHARED env
@marsam marsam merged commit 78dc753 into NixOS:master Jun 26, 2022
@jiegec jiegec deleted the cocotb-darwin branch July 8, 2022 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@matthuszagh matthuszagh Awaiting requested review from matthuszagh

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiegec @marsam