Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs: 16.15.0 -> 16.15.1, 18.2.0 -> 18.3.0 #175874

Merged
merged 2 commits into from
Jun 2, 2022
Merged

nodejs: 16.15.0 -> 16.15.1, 18.2.0 -> 18.3.0 #175874

merged 2 commits into from
Jun 2, 2022

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jun 2, 2022

Description of changes

https://github.com/nodejs/node/releases/tag/v16.15.1

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@marsam marsam changed the title nodejs-16_x: 16.15.0 -> 16.15.1 nodejs: 16.15.0 -> 16.15.1, 18.2.0 -> 18.3.0 Jun 2, 2022
@marsam marsam merged commit c3dfa1a into NixOS:master Jun 2, 2022
@marsam marsam deleted the update-nodejs-16_x branch June 2, 2022 06:48
@etu
Copy link
Contributor

etu commented Jun 6, 2022

Hey @nyanloutre @minijackson @purcell @jojosch

Somehow e6188b6 broke the build of jellyfin-web.

I'm not sure why, but I did bisect it to break in this commit. The same problem exists on hydra since 3 days ago: https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.jellyfin-web.x86_64-linux

@yu-re-ka
Copy link
Contributor

yu-re-ka commented Jun 6, 2022

Hey @nyanloutre @minijackson @purcell @jojosch

Somehow e6188b6 broke the build of jellyfin-web.

I'm not sure why, but I did bisect it to break in this commit. The same problem exists on hydra since 3 days ago: https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.jellyfin-web.x86_64-linux

#176127

@minijackson
Copy link
Member

I'm not seeing any CVE fixed by the update to nodejs / npm, is it acceptable to revert this commit while waiting for a fix upstream?

@marsam
Copy link
Contributor Author

marsam commented Jun 9, 2022

is it acceptable to revert this commit while waiting for a fix upstream?

yes, reverted in #177002

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants