Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goffice: disable tests on powerpc64le #170567

Merged
merged 1 commit into from Apr 27, 2022
Merged

goffice: disable tests on powerpc64le #170567

merged 1 commit into from Apr 27, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 27, 2022

Description of changes

The goffice tests fail on powerpc64le due to its non-IEEE long double type having unexpected rounding behavior:

FAIL: test-format
===========================================
   goffice 0.10.51: tests/test-suite.log
===========================================

# TOTAL: 3
# PASS:  2
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: test-format
=================

go_render_general: 1.9999999990000001 12 -> "1.999999999"
go_render_general: 1.9999999990000001 11 -> "1.999999999"
go_render_general: 1.9999999990000001 10 -> "1.99999999"
Expected "2"
**
ERROR:test-format.c:22:test_general_format_1: assertion failed: (0)
Bail out! ERROR:test-format.c:22:test_general_format_1: assertion failed: (0)
FAIL test-format (exit status: 134)

============================================================================
Testsuite summary for goffice 0.10.51
============================================================================
# TOTAL: 3
# PASS:  2
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0
============================================================================
See tests/test-suite.log
Please report to https://gitlab.gnome.org/GNOME/goffice/issues
============================================================================
Things done
  • Built on platform(s)
    • powerpc64le-linux
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ghost
Copy link
Author

ghost commented Apr 27, 2022

See also #170402

@ghost ghost marked this pull request as ready for review April 27, 2022 04:27
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 27, 2022
@Mindavi Mindavi merged commit ff769e6 into NixOS:master Apr 27, 2022
@ghost ghost deleted the goffice-disable-tests-on-powerpc64le branch April 27, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant