Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

open-stage-control: init at 1.17.0 #170464

Merged
merged 1 commit into from
Jul 7, 2022
Merged

open-stage-control: init at 1.17.0 #170464

merged 1 commit into from
Jul 7, 2022

Conversation

lilyinstarlight
Copy link
Member

@lilyinstarlight lilyinstarlight commented Apr 26, 2022 •
edited
Loading

Description of changes

This PR adds Open Stage Control, an OSC/MIDI controller. It uses the existing node2nix stuff and electron_15 package from nixpkgs, but I had to generate node-packages.nix and node-composition.nix with a newer node2nix version than is in nixpkgs due to #165246 (but the newer version is not required to build or run the package, just to generate the files) (edit: since #171195 was merged using a newer node2nix is no longer needed). I modeled this package on other electron apps in nixpkgs and I've been using this package from my own config for a while now

Fixes #79637

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@lilyinstarlight lilyinstarlight mentioned this pull request Apr 26, 2022
Closed
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 26, 2022
@lilyinstarlight lilyinstarlight force-pushed the pkg/open-stage-control branch from d9c57fe to fc9720e Compare May 1, 2022 14:26
@lilyinstarlight lilyinstarlight changed the title open-stage-control: init at 1.16.0 open-stage-control: init at 1.16.1 May 1, 2022
@lilyinstarlight lilyinstarlight force-pushed the pkg/open-stage-control branch from fc9720e to 8d68307 Compare May 6, 2022 12:36
@lilyinstarlight lilyinstarlight changed the title open-stage-control: init at 1.16.1 open-stage-control: init at 1.16.2 May 6, 2022
@lilyinstarlight lilyinstarlight force-pushed the pkg/open-stage-control branch from 8d68307 to 8efcd49 Compare May 30, 2022 14:35
@lilyinstarlight lilyinstarlight changed the title open-stage-control: init at 1.16.2 open-stage-control: init at 1.16.3 May 30, 2022
@lilyinstarlight lilyinstarlight force-pushed the pkg/open-stage-control branch from 8efcd49 to a12e73d Compare June 1, 2022 15:51
@lilyinstarlight lilyinstarlight changed the title open-stage-control: init at 1.16.3 open-stage-control: init at 1.16.5 Jun 1, 2022
@lilyinstarlight lilyinstarlight force-pushed the pkg/open-stage-control branch from a12e73d to 1019858 Compare June 8, 2022 16:22
@lilyinstarlight lilyinstarlight changed the title open-stage-control: init at 1.16.5 open-stage-control: init at 1.16.6 Jun 8, 2022
@lilyinstarlight lilyinstarlight force-pushed the pkg/open-stage-control branch from 1019858 to f7fa9c8 Compare July 5, 2022 13:56
@lilyinstarlight lilyinstarlight changed the title open-stage-control: init at 1.16.6 open-stage-control: init at 1.17.0 Jul 5, 2022
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/972

SuperSandro2000
SuperSandro2000 reviewed Jul 6, 2022
View reviewed changes
pkgs/applications/audio/open-stage-control/generate-dependencies.sh Outdated
#! nix-shell -i bash -p nodePackages.node2nix

# Download package.json from the release
curl https://raw.githubusercontent.com/jean-emmanuel/open-stage-control/v1.17.0/package.json | grep -v '"electron"\|"electron-installer-debian"\|"electron-packager"\|"electron-packager-plugin-non-proprietary-codecs-ffmpeg"' >package.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoding the version here is not updater friendly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would a variable at the top of the script work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've put a variable at the top of the script for now. Let me know if something else would be better. Thank you!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should fetch the latest release version from the github repository so that the update script just works and does not need manual editing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do that too. I think I copied this script from some other electron app update script, but I have no problem with just making it always fetch latest

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed an update which fetches the latest tag from the GitHub API and then fetches package.json file from that tag

pkgs/applications/audio/open-stage-control/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/open-stage-control/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/open-stage-control/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/open-stage-control/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/open-stage-control/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/open-stage-control/default.nix Outdated Show resolved Hide resolved
@lilyinstarlight lilyinstarlight force-pushed the pkg/open-stage-control branch 3 times, most recently from 984d355 to 6a84d0d Compare July 6, 2022 21:59
@lilyinstarlight lilyinstarlight force-pushed the pkg/open-stage-control branch from 6a84d0d to 1b1684c Compare July 7, 2022 14:27
@SuperSandro2000 SuperSandro2000 merged commit f49fe4a into NixOS:master Jul 7, 2022
@lilyinstarlight lilyinstarlight deleted the pkg/open-stage-control branch July 7, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Open Stage Control
3 participants
@lilyinstarlight @nixos-discourse @SuperSandro2000