Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

powerpc64*: use --with-long-double-format=ieee #170215

Merged
merged 13 commits into from Apr 16, 2023
Merged

powerpc64*: use --with-long-double-format=ieee #170215

merged 13 commits into from Apr 16, 2023

Commits on Apr 5, 2023

  1. gnulib: add gnulib-longdouble-redirect.patch 

    This patch adds gnulib-longdouble-redirect.patch, which is a subset of
gnulib commit 776af40e09b476a41073131a90022572f448c189.

This patch must be applied to the copy of gnulib which is vendored
within a few packages, when compiling for platforms that use
longdouble-redirection (a glibc-specific feature).  Without it,
compile failures mentioning "__LDBL_REDIR1_DECL" will occur.

Currently there are two packages which need this patch to their
vendored gnulib: gettext and gnused.  Both projects have merged a
fixed version of gnulib but have not yet made a release with the fix.
We can drop this patch as soon as both of those projects are
version-bumped.
    Adam Joseph committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    9eafe43 View commit details
    Browse the repository at this point in the history

  2. gnused: apply gnulib.passthru.longdouble-redirect-patch

    Adam Joseph committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    1fa5ff7 View commit details
    Browse the repository at this point in the history

  3. gettext: apply gnulib.passthru.longdouble-redirect-patch

    Adam Joseph committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    810c6c3 View commit details
    Browse the repository at this point in the history

  4. texinfo: apply gnulib.passthru.longdouble-redirect-patch 

    Co-authored-by: Sandro <[email protected]>
    @SuperSandro2000
    Adam Joseph and SuperSandro2000 committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    5d64ebd View commit details
    Browse the repository at this point in the history

  5. mpfr: add --disable-decimal-float 

    Co-authored-by: Sandro <[email protected]>
    @SuperSandro2000
    Adam Joseph and SuperSandro2000 committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    cee9981 View commit details
    Browse the repository at this point in the history

  6. libpipeline: apply gnulib.passthru.longdouble-redirect-patch

    Adam Joseph committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    e2d44f6 View commit details
    Browse the repository at this point in the history

  7. libpipeline: 1.5.4 -> 1.5.6 

    This commit bumps libpipeline and drops the gnulib patch since the
vendored copy of gnulib has been updated.  I avoided squashing this
commit into the previous one since knowing how to patch libpipeline
1.5.4 without upgrading might be useful (for example, in a git bisect
or cherry-pick).
    Adam Joseph committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    52cf8fe View commit details
    Browse the repository at this point in the history

  8. gcc: if isPower64 && !isMusl use --with-long-double-format=ieee 

    Use IEEE-standard floating point on `powerpc64le` instead of
IBM-proprietary formats.  The GCC wiki has more details on the history
here:

  https://gcc.gnu.org/wiki/Ieee128PowerPC

Nixpkgs' stdenv has no legacy `powerpc64le` installs to deal with
(stdenv did not bootstrap on powerpc64le until very recenty), so it's
much easier decision for us.

Red Hat (i.e. IBM) has tried to do this in each of the last *six*
releases:

  https://fedoraproject.org/wiki/Changes/PPC64LE_Float128_Transition

they and finally shipped it in May with Fedora 36:

  https://bugzilla.redhat.com/show_bug.cgi?id=1649936

Apparently glibc 2.35 fixes the last blocker.

Co-authored-by: Sandro <[email protected]>
    @SuperSandro2000
    Adam Joseph and SuperSandro2000 committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    40f7300 View commit details
    Browse the repository at this point in the history

  9. Revert "goffice: disable tests on powerpc64le" 

    This reverts commit dd2bc2a.

Co-authored-by: Sandro <[email protected]>
    @SuperSandro2000
    Adam Joseph and SuperSandro2000 committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    aeae5ca View commit details
    Browse the repository at this point in the history

  10. glibc: suppress warning about IEEE-standard long double

    Adam Joseph committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    c5a4cc8 View commit details
    Browse the repository at this point in the history

  11. gcc: make --with-long-double-format configurable by targetPlatform.gcc

    Adam Joseph committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    29b3953 View commit details
    Browse the repository at this point in the history

  12. gcc: only pass --with-long-double-format if gcc allows it

    Adam Joseph committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    deda18b View commit details
    Browse the repository at this point in the history

  13. drop gnused gnulib.passthru.longdouble-redirect-patch 

    This reverts commit d455973ece7f51907e86fa4e69947ae0eca6bfa1.
    Adam Joseph committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    0ce0096 View commit details
    Browse the repository at this point in the history