Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/manual: re-generate #168596

Closed
wants to merge 1 commit into from

Conversation

aforemny
Copy link
Contributor

@aforemny aforemny commented Apr 14, 2022

Somewhere between cd67b4f and b0c6127, there were changes to the generated NixOS manual which have not yet been committed.

This creates noise in other issues updating the manual, ie. #162550.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Somewhere between cd67b4f and
b0c6127, there were changes to the
generated NixOS manual which have not yet been committed.
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation labels Apr 14, 2022
@aforemny aforemny mentioned this pull request Apr 14, 2022
13 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Apr 14, 2022
@alyssais
Copy link
Member

alyssais commented Apr 14, 2022

I think a better (and more long-term) solution would be to have the script pin its pandoc version — see #168598.

@aforemny
Copy link
Contributor Author

I think a better (and more long-term) solution would be to have the script pin its pandoc version — see #168598.

I agree that that would be a preferable solution. Thanks! I will close here once #168598 is merged!

@alyssais
Copy link
Member

Superseded by #168598.

@alyssais alyssais closed this Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants