nixos/networkmanager: Allow overriding installed plug-ins #164531
Conversation
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
| ''; | ||
| }; | ||
| in | ||
| types.listOf networkManagerPluginPackage; | ||
| default = [ ]; |
There was a problem hiding this comment.
it might be helpful to add a defaultText listing the plugins added by default. if the docs say Default: [ ] we'd assume that no plugins would be loaded, which is not what's happening.
There was a problem hiding this comment.
I added a note to the description (defaultText IMO would not be not right since we do not set the default value but rather the regular value).
There was a problem hiding this comment.
This whole thing looks really off to me. Why have an option with no default if it effectively has one? If there is a default value, then shouldn't it be set at the option declaration location and not somewhere else?
There was a problem hiding this comment.
If you use default, and user sets networking.networkmanager.plugins, the default will not be used. Whereas this way, it will be merged. And people will be able to use lib.mkForce to replace the pseudo-default value.
Now, one can just use `networking.networkmanager.plugins = lib.mkForce [];` if they want to get rid of the plug-ins. Co-authored-by: lassulus <[email protected]>
|
Does this still work? I put this in my config and on rebuild I can still see openconnect and gtk3 trying to build. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/networkmanager-plugins-installed-by-default/39682/8 |
Description of changes
Now, one can just use
networking.networkmanager.plugins = lib.mkForce [];if they want to get rid of the plug-ins.Alternative implementation of #140666
Fixes: #137338
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes