Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.dnspython: fix tests #161740

Merged
merged 1 commit into from
Feb 27, 2022
Merged

python3Packages.dnspython: fix tests #161740

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkgs/development/python-modules/dnspython/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
{ lib
, stdenv
, buildPythonPackage
, fetchPypi
, pythonOlder
, setuptools-scm
, pytestCheckHook
, cacert
}:

buildPythonPackage rec {
Expand All @@ -19,11 +21,15 @@ buildPythonPackage rec {

checkInputs = [
pytestCheckHook
] ++ lib.optional stdenv.isDarwin [
cacert
];

disabledTests = [
# dns.exception.SyntaxError: protocol not found
"test_misc_good_WKS_text"
# fails if IPv6 isn't available
"test_resolver_override"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a darwin-only fix? I would have thought the build sandbox would prevent host IPv6 setup from being visible to the build?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that sounds like the origin of the error.

Either way, this fixes an existing regression. We can explore alternatives in another PR.

];

nativeBuildInputs = [
Expand Down