Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/duplicati: Add dataDir to service #152043

Merged
merged 1 commit into from
Dec 29, 2021
Merged

nixos/duplicati: Add dataDir to service #152043

merged 1 commit into from
Dec 29, 2021

Conversation

Lyndeno
Copy link
Contributor

@Lyndeno Lyndeno commented Dec 24, 2021 •
edited
Loading

Motivation for this change

Other services such as minecraft-server and plex allow configuration of
the dataDir option, allowing the files stored by each service to be in a
custom location.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: changelog 8.has: documentation This PR adds or changes documentation labels Dec 24, 2021
@Lyndeno Lyndeno marked this pull request as ready for review December 24, 2021 22:26
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 24, 2021
aanderse
aanderse reviewed Dec 25, 2021
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Lyndeno 👋 Thanks for opening this PR - I see it is your first for nixpkgs! 🎉

I have left a few comments for you to review. I hope you find them helpful. If you have any questions at all please do not hesitate at all to ask. I would be happy to help! Hopefully we can make your first PR a great experience.

Thanks!

@Lyndeno
Copy link
Contributor Author

Lyndeno commented Dec 25, 2021

Hey @aanderse, I have applied your suggestions to the branch. I wasn't sure on the best practice to replace my first commit so I just co-authored you on a commit with the relevant changes, I hope that is fine. Thank you for reviewing my PR, this is also pretty much my first PR on any project not my own so I this is pretty new to me!

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 25, 2021
@Lyndeno
Copy link
Contributor Author

Lyndeno commented Dec 29, 2021

Hi @aanderse, I have fixed up my mistake and fixed a merge conflict. Please let me know if their is anything else I can do.

@aanderse
Copy link
Member

@ofborg eval

@aanderse
Copy link
Member

@Lyndeno can you please squash all commits into a single commit? Thanks!

@Lyndeno @aanderse
nixos/duplicati: Add dataDir to service
c7008f8 
Other services such as minecraft-server and plex allow configuration of
the dataDir option, allowing the files stored by each service to be in a
custom location.

Co-authored-by: Aaron Andersen <[email protected]>
@Lyndeno
Copy link
Contributor Author

Lyndeno commented Dec 29, 2021

Squashed, thanks!

aanderse
aanderse approved these changes Dec 29, 2021
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@aanderse aanderse merged commit 4ceea68 into NixOS:master Dec 29, 2021
@Lyndeno Lyndeno deleted the duplicati-dataDir branch December 30, 2021 00:42
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lyndeno @aanderse @Janik-Haag