minecraft: use makeLibraryPath, so we don't use the dev outputs #15124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joachifm
added
0.kind: bug
|
It's worth noting that this is, by itself, already a useful refactoring, independent of whatever we do to the order of outputs. |
| @@ -39,8 +40,7 @@ in stdenv.mkDerivation { | |||
| cat > $out/bin/minecraft << EOF | |||
| #!${stdenv.shell} | |||
|
|
|||
| # wrapper for minecraft | |||
| export LD_LIBRARY_PATH=\$LD_LIBRARY_PATH:${libX11}/lib/:${libXext}/lib/:${libXcursor}/lib/:${libXrandr}/lib/:${libXxf86vm}/lib/:${mesa}/lib/:${openal}/lib/ | |||
| export LD_LIBRARY_PATH=\$LD_LIBRARY_PATH:${makeLibraryPath [ libXext libXcursor libXrandr libXxf86vm mesa openal ]} | |||
There was a problem hiding this comment.
didn't appear to be, no — Minecraft runs fine here.
|
Readded libX11 just in case old Minecraft releases rely on it (since the version selector in the launcher allows you to play older releases) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now it ends up using the .dev outputs, due to fallout from closure-size, and breaks hard.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)